[clang-linker-wrapper][NFC] Invert condition for readability #161557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find the positive expressions easier to read than negative.
Member
|
@llvm/pr-subscribers-clang Author: Alexey Bader (bader) ChangesI find the positive expressions easier to read than negative. Full diff: https://github.com/llvm/llvm-project/pull/161557.diff 1 Files Affected:
diff --git a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
index be658acacb406..1419b8c90a625 100644
--- a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
+++ b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
@@ -608,10 +608,10 @@ Expected<StringRef> linkDevice(ArrayRef<StringRef> InputFiles,
Error containerizeRawImage(std::unique_ptr<MemoryBuffer> &Img, OffloadKind Kind,
const ArgList &Args) {
llvm::Triple Triple(Args.getLastArgValue(OPT_triple_EQ));
- if (Kind != OFK_OpenMP || !Triple.isSPIRV() ||
- Triple.getVendor() != llvm::Triple::Intel)
- return Error::success();
- return offloading::intel::containerizeOpenMPSPIRVImage(Img);
+ if (Kind == OFK_OpenMP && Triple.isSPIRV() &&
+ Triple.getVendor() == llvm::Triple::Intel)
+ return offloading::intel::containerizeOpenMPSPIRVImage(Img);
+ return Error::success();
}
Expected<StringRef> writeOffloadFile(const OffloadFile &File) {
|
sarnex
approved these changes
Oct 1, 2025
jhuber6
approved these changes
Oct 1, 2025
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/14588 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/85/builds/14069 Here is the relevant piece of the build log for the reference |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
…1557) I find the positive expressions easier to read than negative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find the positive expressions easier to read than negative.