Skip to content

Conversation

bulbazord
Copy link
Member

@bulbazord bulbazord commented Oct 2, 2025

The cpp file fails to build without lld-link.

The cpp file fails to compile without `lld-link`.
@bulbazord bulbazord requested a review from Nerixyz October 2, 2025 20:39
@llvmbot llvmbot added the lldb label Oct 2, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 2, 2025

@llvm/pr-subscribers-lldb

Author: Alex Langford (bulbazord)

Changes

The cpp file fails to build without lld-link.


Full diff: https://github.com/llvm/llvm-project/pull/161731.diff

1 Files Affected:

  • (modified) lldb/test/Shell/SymbolFile/NativePDB/symtab.cpp (+1-1)
diff --git a/lldb/test/Shell/SymbolFile/NativePDB/symtab.cpp b/lldb/test/Shell/SymbolFile/NativePDB/symtab.cpp
index 81d643d9572d8..beb5ae2f90256 100644
--- a/lldb/test/Shell/SymbolFile/NativePDB/symtab.cpp
+++ b/lldb/test/Shell/SymbolFile/NativePDB/symtab.cpp
@@ -1,4 +1,4 @@
-// REQUIRES: x86
+// REQUIRES: lld, x86
 
 // Test symtab reading
 // RUN: %build --compiler=clang-cl --arch=64 --nodefaultlib -o %t.exe -- %s

Copy link
Contributor

@Nerixyz Nerixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing!

@bulbazord bulbazord merged commit dbffd0a into llvm:main Oct 2, 2025
9 of 10 checks passed
@bulbazord bulbazord deleted the native-pdb-lld-test branch October 2, 2025 20:50
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Oct 3, 2025
The cpp file fails to build without `lld-link`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants