[ASTMatchers] Why is `GtestMatchers.h` in the source tree?

[localspook]

These matchers aren't used anywhere in the monorepo; in fact, they aren't used anywhere on GitHub, as far as I can tell. It seems weird to have matchers for one very specific library right here in the LLVM tree, and I can't find the rationale behind it (the original DR, for example, doesn't really provide any). I would say they should be deleted, unless there's some reason I'm missing.

[localspook]

cc @ymand as author of original DR

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Victor Chernyakin (localspook)

These matchers [aren't used anywhere in the monorepo](https://github.com/search?q=repo%3Allvm%2Fllvm-project+%2FGtestMatchers.h%5B%22%3E%5D%2F&type=code); in fact, they [aren't used anywhere on GitHub](https://github.com/search?q=%2FGtestMatchers.h%5B%22%3E%5D%2F&type=code), as far as I can tell. It seems weird to have matchers for one very specific library right here in the LLVM tree, and I can't find the rationale behind it (the [original DR](https://reviews.llvm.org/D74840), for example, doesn't really provide any). I would say they should be deleted, unless there's some reason I'm missing.

[cor3ntin]

This does indeed look like it's not used upstream and we should almost certainly remove it

[AaronBallman]

Agreed, I think these should be removed if there's not in-tree uses of them. Seems like potentially a good first issue?

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor is working on this issue. If someone is assigned to the issue or claimed to be working on it, ping the person. After one week without a response, the assignee may be changed.
2. Leave a comment indicating that you are working on the issue, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Victor Chernyakin (localspook)

These matchers [aren't used anywhere in the monorepo](https://github.com/search?q=repo%3Allvm%2Fllvm-project+%2FGtestMatchers.h%5B%22%3E%5D%2F&type=code); in fact, they [aren't used anywhere on GitHub](https://github.com/search?q=%2FGtestMatchers.h%5B%22%3E%5D%2F&type=code), as far as I can tell. It seems weird to have matchers for one very specific library right here in the LLVM tree, and I can't find the rationale behind it (the [original DR](https://reviews.llvm.org/D74840), for example, doesn't really provide any). I would say they should be deleted, unless there's some reason I'm missing.

[Thibault-Monnier]

I'd be happy to work on this.

[localspook]

Go for it! We look forward to your PR