[LLVM-C] Upstream LLVMGetOrInsertFunction from rustc
#162235
Conversation
|
As I'm not very familiar with the llvm-c codebase I'm not sure where to add tests for the new function. Any help or directions would be appreciated :) |
Either llvm/tools/llvm-c-test or llvm/unittests/IR/FunctionTest.cpp would work. Probably the latter in this case (see the last test function there). |
AMS21
force-pushed
the
upstream_get_or_insert_function
branch
from
59cc9ec to
aa16c22
Compare
There was a problem hiding this comment.
Can you please add an entry to llvm/docs/ReleaseNotes.md and add a proper PR description?
Otherwise this looks like. It's already possible to achieve this using LLVMAddFunction + LLVMGetNamedFunction, but getOrInsertFunction() is generally the more idiomatic way to insert declarations, so it makes sense to me to provide it directly.
AMS21
force-pushed
the
upstream_get_or_insert_function
branch
from
aa16c22 to
6539a2d
Compare
Add `LLVMGetOrInsertFunction` to the C API as a thin wrapper over `Module::getOrInsertFunction`, upstreamed from rustc (https://github.com/rust-lang/rust/blob/d773bd07d63a74adcf25ea5f4aae986be94cac5e/compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp#L203) It provides a single-call way to get or create a function declaration, avoiding `LLVMGetNamedFunction` + `LLVMAddFunction` and is more idiomatic.
AMS21
force-pushed
the
upstream_get_or_insert_function
branch
from
6539a2d to
756bae5
Compare
Add
LLVMGetOrInsertFunctionto the C API as a thin wrapper overModule::getOrInsertFunction, upstreamed from rustc.It provides a single-call way to get or create a function declaration, avoiding
LLVMGetNamedFunction+LLVMAddFunctionand is more idiomatic.