Skip to content

Conversation

@bgergely0
Copy link
Contributor

PR #120064 added several MCPlusBuilder helpers for recognising
instructions which sign or authenticate the link register.

This patch adds MCPlusBuilder unittests for these helpers.

Copy link
Contributor Author

bgergely0 commented Oct 7, 2025

@bgergely0 bgergely0 marked this pull request as ready for review October 7, 2025 09:42
@bgergely0 bgergely0 added the BOLT label Oct 7, 2025
@bgergely0
Copy link
Contributor Author

Hmm, not sure what the failure in the auto-subscribe job is. This is my first PR from a user branch, could be related?

@paschalis-mpeis
Copy link
Member

It looks like it is unrelated:

@bgergely0 bgergely0 marked this pull request as draft October 8, 2025 07:46
@bgergely0 bgergely0 force-pushed the users/bgergely0/bolt-pauth-unittests branch from c17529a to f5b7079 Compare October 8, 2025 11:49
@bgergely0 bgergely0 marked this pull request as ready for review October 8, 2025 12:03
Copy link
Member

@paschalis-mpeis paschalis-mpeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the unit tests Gergely.
Maybe we could add the XZR variants (PACIZA/PACIAZ) ?

PR #120064 added several MCPlusBuilder helpers for recognising
instructions which sign or authenticate the link register.

This patch adds MCPlusBuilder unittests for these helpers.
@bgergely0 bgergely0 force-pushed the users/bgergely0/bolt-pauth-unittests branch from f5b7079 to 38f4ab2 Compare October 15, 2025 14:48
Copy link
Contributor Author

Added!

@bgergely0 bgergely0 merged commit db2d8fc into main Oct 16, 2025
10 checks passed
@bgergely0 bgergely0 deleted the users/bgergely0/bolt-pauth-unittests branch October 16, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants