[LifetimeSafety] Refactor the analysis into smaller files #162474
+2,063
−1,653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Restructure the C++ Lifetime Safety Analysis into a modular, component-based architecture with clear separation of concerns.
What changed?
This PR reorganizes the C++ Lifetime Safety Analysis code by:
LifetimeSafety.cpp
(1500+ lines) into multiple smaller, focused filesLifetimeSafety
directory with a clean component structureChecker.h/cpp
: Core lifetime checking logicDataflow.h
: Generic dataflow analysis frameworkFacts.h
: Lifetime-relevant events and fact managementFactsGenerator.h/cpp
: AST traversal for fact generationLiveOrigins.h/cpp
: Backward dataflow analysis for origin livenessLoanPropagation.h/cpp
: Forward dataflow analysis for loan trackingLoans.h
: Loan and access path definitionsOrigins.h
: Origin managementReporter.h
: Interface for reporting lifetime violationsUtils.h
: Common utilities for the analysisThe code functionality remains the same, but is now better organized with clearer interfaces between components.
Why make this change?
This restructuring improves maintainability and extensibility of the lifetime safety analysis by: