[libc] skip sysconf test for rv32 #162669
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lntue
approved these changes
Oct 9, 2025
SchrodingerZhu
force-pushed
the
libc/skip-sysconf-for-rv32
branch
from
d96e747 to
8c22e9d
Compare
|
@llvm/pr-subscribers-libc Author: Schrodinger ZHU Yifan (SchrodingerZhu) ChangesThe issue is being investigated. For now, let's skip the test to keep the bot running see #162671 Full diff: https://github.com/llvm/llvm-project/pull/162669.diff 1 Files Affected:
diff --git a/libc/test/src/unistd/sysconf_test.cpp b/libc/test/src/unistd/sysconf_test.cpp
index 85bc1258a4863..e6a35c70f29e8 100644
--- a/libc/test/src/unistd/sysconf_test.cpp
+++ b/libc/test/src/unistd/sysconf_test.cpp
@@ -13,5 +13,9 @@
TEST(LlvmLibcSysconfTest, PagesizeTest) {
long pagesize = LIBC_NAMESPACE::sysconf(_SC_PAGESIZE);
+ // TODO: fix page size support on RV32
+ // (https://github.com/llvm/llvm-project/issues/162671)
+#ifndef LIBC_TARGET_ARCH_IS_RISCV32
ASSERT_GT(pagesize, 0l);
+#endif
}
|
auto-merge was automatically disabled
October 9, 2025 15:31
Pull Request is not mergeable
|
I think I have identified the error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is being investigated. For now, let's skip the test to keep the bot running
see #162671