[TSan][Test-Only] Mark write-interpose.c unsupported on ios #163178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is currently failing on ios-sim. This patch follows other sanitizer tests that use DYLD_INSERT_LIBRARIES and marks itself unsupported on ios platforms. rdar://162287951
llvmbot
added
compiler-rt
compiler-rt:tsan
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Dan Blackwell (DanBlackwell) ChangesThis test is currently failing on ios-sim. This patch follows other sanitizer tests that use DYLD_INSERT_LIBRARIES and marks itself unsupported on ios platforms. rdar://162287951 Full diff: https://github.com/llvm/llvm-project/pull/163178.diff 1 Files Affected:
diff --git a/compiler-rt/test/tsan/Darwin/write-interpose.c b/compiler-rt/test/tsan/Darwin/write-interpose.c
index cbd9a0867c982..51ff3ee3d0df9 100644
--- a/compiler-rt/test/tsan/Darwin/write-interpose.c
+++ b/compiler-rt/test/tsan/Darwin/write-interpose.c
@@ -7,6 +7,8 @@
// Note that running the below command with out `lock_during_write` should
// deadlock (self-lock)
// RUN: env DYLD_INSERT_LIBRARIES=%t.dylib TSAN_OPTIONS=verbosity=2:lock_during_write=disable_for_current_process %run %t 2>&1 | FileCheck %s
+//
+// UNSUPPORTED: ios
#include <stdio.h>
|
|
nit: I'd prefer a note saying why it's unsupported for future dev's sake or finding these in the future if we can enable them. |
|
I will merge this now to stop the CI noise; but I think that we may be able to mark many of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is currently failing on ios-sim. This patch follows other sanitizer tests that use DYLD_INSERT_LIBRARIES and marks itself unsupported on ios platforms.
rdar://162287951