Skip to content

Conversation

@jurahul
Copy link
Contributor

@jurahul jurahul commented Oct 13, 2025

No description provided.

@jurahul jurahul marked this pull request as ready for review October 13, 2025 14:06
@jurahul jurahul requested a review from joker-eph October 13, 2025 14:06
@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir labels Oct 13, 2025
@jurahul jurahul requested a review from jpienaar October 13, 2025 14:06
@llvmbot
Copy link
Member

llvmbot commented Oct 13, 2025

@llvm/pr-subscribers-mlir-core

@llvm/pr-subscribers-mlir

Author: Rahul Joshi (jurahul)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/163197.diff

1 Files Affected:

  • (modified) mlir/lib/IR/AsmPrinter.cpp (+3-4)
diff --git a/mlir/lib/IR/AsmPrinter.cpp b/mlir/lib/IR/AsmPrinter.cpp
index 3d19c5ad8fbca..9b23dd6e4f283 100644
--- a/mlir/lib/IR/AsmPrinter.cpp
+++ b/mlir/lib/IR/AsmPrinter.cpp
@@ -2200,10 +2200,9 @@ void AsmPrinter::Impl::printLocationInternal(LocationAttr loc, bool pretty,
           os << '>';
         }
         os << '[';
-        interleave(
-            loc.getLocations(),
-            [&](Location loc) { printLocationInternal(loc, pretty); },
-            [&]() { os << ", "; });
+        interleaveComma(loc.getLocations(), [&](Location loc) {
+          printLocationInternal(loc, pretty);
+        });
         os << ']';
       })
       .Default([&](LocationAttr loc) {

@jurahul jurahul merged commit b06e0a2 into llvm:main Oct 13, 2025
15 checks passed
@jurahul jurahul deleted the mlir_use_interleave_comma branch October 13, 2025 14:34
akadutta pushed a commit to akadutta/llvm-project that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mlir:core MLIR Core Infrastructure mlir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants