Skip to content

Conversation

@jackalcooper
Copy link
Contributor

image

@llvmbot llvmbot added the mlir label Oct 14, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 14, 2025

@llvm/pr-subscribers-mlir

Author: Shenghang Tsai (jackalcooper)

Changes

<img width="889" height="138" alt="image" src="https://github.com/user-attachments/assets/5a907cd7-beed-4a03-9d5e-43ec594d1e04" />


Full diff: https://github.com/llvm/llvm-project/pull/163409.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/Shard/IR/ShardOps.td (+1-1)
diff --git a/mlir/include/mlir/Dialect/Shard/IR/ShardOps.td b/mlir/include/mlir/Dialect/Shard/IR/ShardOps.td
index 29b384f401876..b9d7163ea4c1e 100644
--- a/mlir/include/mlir/Dialect/Shard/IR/ShardOps.td
+++ b/mlir/include/mlir/Dialect/Shard/IR/ShardOps.td
@@ -174,7 +174,7 @@ def Shard_NeighborsLinearIndicesOp : Shard_Op<"neighbors_linear_indices", [
     ```
     The above returns two indices, `633` and `693`, which correspond to the
     index of the previous process `(1, 1, 3)`, and the next process 
-    `(1, 3, 3) along the split axis `1`.
+    `(1, 3, 3)` along the split axis `1`.
 
     A negative value is returned if there is no neighbor in the respective
     direction along the given `split_axes`.

@PragmaTwice
Copy link
Member

I'll merge this tiny typo fix soon. cc @fschlimb @sogartar

@PragmaTwice PragmaTwice changed the title [MLIR] Fix Markdown docs of shard.neighbors_linear_indices [MLIR][shard] Fix tblgen description of shard.neighbors_linear_indices Oct 15, 2025
Copy link
Contributor

@fschlimb fschlimb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PragmaTwice PragmaTwice merged commit fbd6ac3 into llvm:main Oct 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants