[libclc] Fix double NAN_MASK in __clc_nan #163522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x7ff0000000000000 is +inf. Change it to quiet nan 0x7ff8000000000000.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an incorrect NaN mask value for 64-bit floating point numbers in libclc. The value 0x7ff0000000000000 represents positive infinity, not NaN, and is corrected to 0x7ff8000000000000 which represents a quiet NaN.
- Corrects the NAN_MASK constant for 64-bit floating point from positive infinity to quiet NaN
wenju-he
changed the title
wenju-he
added a commit
to wenju-he/llvm
that referenced
this pull request
Oct 15, 2025
…pirv_ocl_nan NAN_MASK fix is cherry-pick of llvm/llvm-project#163522 Also fix a few build warnings `'__CLC_FUNCTION' macro redefined`.
arsenm
reviewed
Oct 15, 2025
done in de867d4 |
frasercrmck
approved these changes
Oct 17, 2025
|
Oh right I forgot about the weird string format for __builtin_nan. Technically you could try to find a string to map the value to |
|
It's probably better to go back to not using the builtin, failing a way to get the string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0x7ff0000000000000 is +inf. Change it to quiet nan 0x7ff8000000000000.