Skip to content

Conversation

@hazzlim
Copy link
Contributor

@hazzlim hazzlim commented Oct 15, 2025

No description provided.

@llvmbot llvmbot added the llvm:SelectionDAG SelectionDAGISel as well label Oct 15, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 15, 2025

@llvm/pr-subscribers-llvm-selectiondag

Author: Hari Limaye (hazzlim)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/163527.diff

1 Files Affected:

  • (modified) llvm/include/llvm/CodeGen/SelectionDAGNodes.h (+1-1)
diff --git a/llvm/include/llvm/CodeGen/SelectionDAGNodes.h b/llvm/include/llvm/CodeGen/SelectionDAGNodes.h
index 116911699ab9f..69713d0d84011 100644
--- a/llvm/include/llvm/CodeGen/SelectionDAGNodes.h
+++ b/llvm/include/llvm/CodeGen/SelectionDAGNodes.h
@@ -1950,7 +1950,7 @@ LLVM_ABI bool isOnesOrOnesSplat(SDValue N, bool AllowUndefs = false);
 
 /// Return true if the value is a constant 0 integer or a splatted vector of a
 /// constant 0 integer (with no undefs).
-/// Does not permit build vector implicit truncation.
+/// Build vector implicit truncation is allowed.
 LLVM_ABI bool isZeroOrZeroSplat(SDValue N, bool AllowUndefs = false);
 
 /// Return true if \p V is either a integer or FP constant.

@hazzlim hazzlim requested review from arcbbb and arsenm October 15, 2025 09:04
@RKSimon RKSimon merged commit bf64316 into llvm:main Oct 15, 2025
12 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Oct 15, 2025

LLVM Buildbot has detected a new failure on builder ppc64le-mlir-rhel-clang running on ppc64le-mlir-rhel-test while building llvm at step 3 "clean-build-dir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/129/builds/31497

Here is the relevant piece of the build log for the reference
Step 3 (clean-build-dir) failure: Delete failed. (failure) (timed out)
Step 6 (test-build-check-mlir-build-only-check-mlir) failure: 1200 seconds without output running [b'ninja', b'check-mlir'], attempting to kill
...
PASS: MLIR-Unit :: IR/./MLIRIRTests/101/130 (3538 of 3549)
PASS: MLIR-Unit :: IR/./MLIRIRTests/0/130 (3539 of 3549)
PASS: MLIR-Unit :: IR/./MLIRIRTests/39/130 (3540 of 3549)
PASS: MLIR-Unit :: IR/./MLIRIRTests/38/130 (3541 of 3549)
PASS: MLIR-Unit :: Interfaces/./MLIRInterfacesTests/13/22 (3542 of 3549)
PASS: MLIR-Unit :: Interfaces/./MLIRInterfacesTests/11/22 (3543 of 3549)
PASS: MLIR-Unit :: Pass/./MLIRPassTests/10/13 (3544 of 3549)
PASS: MLIR-Unit :: Interfaces/./MLIRInterfacesTests/12/22 (3545 of 3549)
PASS: MLIR-Unit :: IR/./MLIRIRTests/100/130 (3546 of 3549)
PASS: MLIR :: mlir-reduce/dce-test.mlir (3547 of 3549)
command timed out: 1200 seconds without output running [b'ninja', b'check-mlir'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=3973.080377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm:SelectionDAG SelectionDAGISel as well

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants