[clang-format] `BreakAfterAttributes: Leave` does not respect multiple attributes

[duckdoom5]

The clang format setting BreakAfterAttributes: Leave Does not leave the line break(s) between attributes.

Expected formatting:

[[deprecated("Don't use this version")]]
[[nodiscard]] 
bool Test() {
    return true;
}

[[deprecated("Don't use this version")]]
[[nodiscard]] bool Test2() {
    return true;
}

Actual formatting:

[[deprecated("Don't use this version")]] [[nodiscard]]
bool Test() {
    return true;
}

[[deprecated("Don't use this version")]] [[nodiscard]] bool Test2() {
    return true;
}

clang-format version: 19.1.5

[P-Fazil]

Can i work on this ?

[llvmbot]

@llvm/issue-subscribers-clang-format

Author: Jelle (duckdoom5)

The clang format setting `BreakAfterAttributes: Leave` Does not leave the line break(s) between attributes.

Expected formatting:

[[deprecated("Don't use this version")]]
[[nodiscard]] 
bool Test() {
    return true;
}

[[deprecated("Don't use this version")]]
[[nodiscard]] bool Test2() {
    return true;
}

Actual formatting:

[[deprecated("Don't use this version")]] [[nodiscard]]
bool Test() {
    return true;
}

[[deprecated("Don't use this version")]] [[nodiscard]] bool Test2() {
    return true;
}

clang-format version: 19.1.5

[owenca]

The clang format setting BreakAfterAttributes: Leave Does not leave the line break(s) between attributes.

Expected formatting:

[[deprecated("Don't use this version")]]
[[nodiscard]]
bool Test() {
return true;
}

[[deprecated("Don't use this version")]]
[[nodiscard]] bool Test2() {
return true;
}
Actual formatting:

[[deprecated("Don't use this version")]] [[nodiscard]]
bool Test() {
return true;
}

[[deprecated("Don't use this version")]] [[nodiscard]] bool Test2() {
return true;
}
clang-format version: 19.1.5

Option BreakAfterAttributes only applies to the last attribute (not every attribute) before a declaration or control statement. A group of consecutive attributes are still bin packed regardless. The documentation can be made clearer though.

[duckdoom5]

In that case; let me rephrase it as a feature request, since it's rather annoying and there seems to be no way around it

[owenca]

I can see why someone wants one attribute per line (before Test) but don't think we want to support the style in Test2.

[duckdoom5]

Well, I'd prefer the style in Test2 actually.
In my brain the no discard belongs with the return type and the deprecated belongs with the function.
Also adding the message makes it too long to have it on one line most of the time.

That's why I think Leave should leave those breaks alone (as the name of the option would make people believe)

[owenca]

Well, I'd prefer the style in Test2 actually. In my brain the no discard belongs with the return type and the deprecated belongs with the function.

I see.

That's why I think Leave should leave those breaks alone (as the name of the option would make people believe)

We can probably add a new value e.g. LeaveAll.