Skip to content

Conversation

@linuxlonelyeagle
Copy link
Member

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Oct 18, 2025

@llvm/pr-subscribers-mlir

Author: lonely eagle (linuxlonelyeagle)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/164108.diff

1 Files Affected:

  • (modified) mlir/test/Interfaces/TilingInterface/tile-and-fuse-using-interface.mlir (+17-30)
diff --git a/mlir/test/Interfaces/TilingInterface/tile-and-fuse-using-interface.mlir b/mlir/test/Interfaces/TilingInterface/tile-and-fuse-using-interface.mlir
index 8116044594fca..a59c7eec10a99 100644
--- a/mlir/test/Interfaces/TilingInterface/tile-and-fuse-using-interface.mlir
+++ b/mlir/test/Interfaces/TilingInterface/tile-and-fuse-using-interface.mlir
@@ -658,33 +658,20 @@ module attributes {transform.with_named_sequence} {
   }
 }
 
-// CHECK:           func.func private @tile_one_consumer_using_tile_and_fuse(%[[VAL_0:.*]]: tensor<16x128x48x96xf32>, %[[VAL_1:.*]]: tensor<16x96x48x128xf32>) -> tensor<16x96x48x128xf32> {
-// CHECK:             %[[VAL_2:.*]] = arith.constant 0 : index
-// CHECK:             %[[VAL_3:.*]] = arith.constant 16 : index
-// CHECK:             %[[VAL_4:.*]] = arith.constant 128 : index
-// CHECK:             %[[VAL_5:.*]] = arith.constant 48 : index
-// CHECK:             %[[VAL_6:.*]] = arith.constant 96 : index
-// CHECK:             %[[VAL_7:.*]] = arith.constant 1 : index
-// CHECK:             %[[VAL_8:.*]] = scf.for %[[VAL_9:.*]] = %[[VAL_2]] to %[[VAL_3]] step %[[VAL_7]] iter_args(%[[VAL_10:.*]] = %[[VAL_1]]) -> (tensor<16x96x48x128xf32>) {
-// CHECK:               %[[VAL_11:.*]] = scf.for %[[VAL_12:.*]] = %[[VAL_2]] to %[[VAL_4]] step %[[VAL_3]] iter_args(%[[VAL_13:.*]] = %[[VAL_10]]) -> (tensor<16x96x48x128xf32>) {
-// CHECK:                 %[[VAL_14:.*]] = scf.for %[[VAL_15:.*]] = %[[VAL_2]] to %[[VAL_5]] step %[[VAL_3]] iter_args(%[[VAL_16:.*]] = %[[VAL_13]]) -> (tensor<16x96x48x128xf32>) {
-// CHECK:                   %[[VAL_17:.*]] = scf.for %[[VAL_18:.*]] = %[[VAL_2]] to %[[VAL_6]] step %[[VAL_3]] iter_args(%[[VAL_19:.*]] = %[[VAL_16]]) -> (tensor<16x96x48x128xf32>) {
-// CHECK:                     %[[VAL_20:.*]] = tensor.extract_slice %[[VAL_0]]{{\[}}%[[VAL_9]], %[[VAL_12]], %[[VAL_15]], %[[VAL_18]]] [1, 16, 16, 16] [1, 1, 1, 1] : tensor<16x128x48x96xf32> to tensor<1x16x16x16xf32>
-// CHECK:                     %[[VAL_21:.*]] = tensor.extract_slice %[[VAL_19]]{{\[}}%[[VAL_9]], %[[VAL_18]], %[[VAL_15]], %[[VAL_12]]] [1, 16, 16, 16] [1, 1, 1, 1] : tensor<16x96x48x128xf32> to tensor<1x16x16x16xf32>
-// CHECK:                     %[[VAL_22:.*]] = linalg.generic {indexing_maps = [#map, #map1], iterator_types = ["parallel", "parallel", "parallel", "parallel"]} ins(%[[VAL_20]] : tensor<1x16x16x16xf32>) outs(%[[VAL_21]] : tensor<1x16x16x16xf32>) {
-// CHECK:                     ^bb0(%[[VAL_23:.*]]: f32, %[[VAL_24:.*]]: f32):
-// CHECK:                       linalg.yield %[[VAL_23]] : f32
-// CHECK:                     } -> tensor<1x16x16x16xf32>
-// CHECK:                     %[[VAL_25:.*]] = tensor.insert_slice %[[VAL_26:.*]] into %[[VAL_19]]{{\[}}%[[VAL_9]], %[[VAL_18]], %[[VAL_15]], %[[VAL_12]]] [1, 16, 16, 16] [1, 1, 1, 1] : tensor<1x16x16x16xf32> into tensor<16x96x48x128xf32>
-// CHECK:                     scf.yield %[[VAL_25]] : tensor<16x96x48x128xf32>
-// CHECK:                   }
-// CHECK:                   scf.yield %[[VAL_27:.*]] : tensor<16x96x48x128xf32>
-// CHECK:                 }
-// CHECK:                 scf.yield %[[VAL_28:.*]] : tensor<16x96x48x128xf32>
-// CHECK:               }
-// CHECK:               scf.yield %[[VAL_29:.*]] : tensor<16x96x48x128xf32>
-// CHECK:             }
-// CHECK:             return %[[VAL_30:.*]] : tensor<16x96x48x128xf32>
-// CHECK:           }
-// CHECK:         }
-
+// CHECK-LABEL: func private @tile_one_consumer_using_tile_and_fuse
+//  CHECK-SAME:   %[[ARG0:.*]]: tensor<16x128x48x96xf32>
+//  CHECK-SAME:   %[[ARG1:.*]]: tensor<16x96x48x128xf32>
+//       CHECK:   scf.for %[[IV0:[a-zA-Z0-9]+]] =
+//  CHECK-SAME:     iter_args(%[[ITERARG0:.+]] = %[[ARG1]])
+//       CHECK:   scf.for %[[IV1:[a-zA-Z0-9]+]] =
+//  CHECK-SAME:     iter_args(%[[ITERARG1:.+]] = %[[ITERARG0]])
+//       CHECK:   scf.for %[[IV2:[a-zA-Z0-9]+]] =
+//  CHECK-SAME:     iter_args(%[[ITERARG2:.+]] = %[[ITERARG1]])
+//       CHECK:   scf.for %[[IV3:[a-zA-Z0-9]+]] =
+//  CHECK-SAME:     iter_args(%[[ITERARG3:.+]] = %[[ITERARG2]])
+//       CHECK:     %[[TILEDARG0:.*]] = tensor.extract_slice %[[ARG0]]{{\[}}%[[IV0]], %[[IV1]], %[[IV2]], %[[IV3]]]
+//       CHECK:     %[[TILEDARG1:.*]] = tensor.extract_slice %[[ITERARG3]]{{\[}}%[[IV0]], %[[IV3]], %[[IV2]], %[[IV1]]]
+//       CHECK:     %[[RES:.*]] = linalg.generic
+//  CHECK-SAME:     ins(%[[TILEDARG0]]
+//  CHECK-SAME:     outs(%[[TILEDARG1]]
+//       CHECK:     tensor.insert_slice %[[RES:.*]]

Copy link
Member

@ftynse ftynse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the horizontal spacing, it helps reading

@linuxlonelyeagle linuxlonelyeagle merged commit 9df34a1 into llvm:main Oct 22, 2025
10 checks passed
@linuxlonelyeagle linuxlonelyeagle changed the title [mlir][transform] Clearnup tile_one_consumer_using_tile_and_fuse test (NFC) [mlir][transform] Cleanup tile_one_consumer_using_tile_and_fuse test (NFC) Oct 22, 2025
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants