Skip to content

Conversation

@tarunprabhu
Copy link
Contributor

@tarunprabhu tarunprabhu commented Oct 20, 2025


Notes for reviewers:

  • In some of the documents, F18 was used to reference both the compiler and, to the best of my understanding, the Fortran 2018 standard. I have solicited extra reviews to make sure that I have not replaced "F18" with "Flang" incorrectly.

  • This is not dependent on Part 1, though I intend to commit them in order

  • IntrinsicTypes.md has not been edited because there is a PR open to perform some unrelated edits, and the f18 -> flang replacement in that file could be folded into that one.

@llvmbot llvmbot added the flang Flang issues not falling into any other category label Oct 20, 2025
@Meinersbur
Copy link
Member

Meinersbur commented Oct 20, 2025

Can you remove the trailing whitespace changes from the patch? It adds a lot of noise.

It would be OK to add a "Part 0" patch for just removing trailing newlines

@tarunprabhu
Copy link
Contributor Author

Can you remove the trailing whitespace changes from the patch? It adds a lot of noise.

It would be OK to add a "Part 0" patch for just removing trailing newlines

Done. I'll do the same on the other PR in a little bit.

@sscalpone
Copy link
Contributor

@razvanlupusoru fyi acc doc changes

Copy link
Contributor

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tarunprabhu tarunprabhu merged commit e866c44 into llvm:main Oct 27, 2025
11 checks passed
@tarunprabhu tarunprabhu deleted the f18-to-flang-2 branch October 27, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang Flang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants