-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[llvm][dwarfdump][docs] Mention DW_AT_linkage_name in --name doc #164433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The `llvm-dwarfdump --name=<name>` option accepts `DW_AT_linkage_name` names too.
|
@llvm/pr-subscribers-llvm-binary-utilities Author: Michael Buch (Michael137) ChangesThe Full diff: https://github.com/llvm/llvm-project/pull/164433.diff 2 Files Affected:
diff --git a/llvm/docs/CommandGuide/llvm-dwarfdump.rst b/llvm/docs/CommandGuide/llvm-dwarfdump.rst
index 27ad4226e6cf9..137830259eb64 100644
--- a/llvm/docs/CommandGuide/llvm-dwarfdump.rst
+++ b/llvm/docs/CommandGuide/llvm-dwarfdump.rst
@@ -83,7 +83,7 @@ OPTIONS
.. option:: -n <name>, --name=<name>
Find and print all debug info entries whose name
- (`DW_AT_name` attribute) is <name>.
+ (`DW_AT_name`/`DW_AT_linkage_name` attribute) is <name>.
.. option:: --lookup=<address>
diff --git a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
index 79f05278c329d..11eb58ea911df 100644
--- a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
+++ b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
@@ -202,9 +202,10 @@ static alias IgnoreCaseAlias("i", desc("Alias for --ignore-case."),
aliasopt(IgnoreCase), cl::NotHidden);
static list<std::string> Name(
"name",
- desc("Find and print all debug info entries whose name (DW_AT_name "
- "attribute) matches the exact text in <pattern>. When used with the "
- "the -regex option <pattern> is interpreted as a regular expression."),
+ desc("Find and print all debug info entries whose name "
+ "(DW_AT_name/DW_AT_linkage_name attribute) matches the exact text "
+ "in <pattern>. When used with the the -regex option <pattern> is "
+ "interpreted as a regular expression."),
value_desc("pattern"), cat(DwarfDumpCategory));
static alias NameAlias("n", desc("Alias for --name"), aliasopt(Name),
cl::NotHidden);
|
|
@llvm/pr-subscribers-debuginfo Author: Michael Buch (Michael137) ChangesThe Full diff: https://github.com/llvm/llvm-project/pull/164433.diff 2 Files Affected:
diff --git a/llvm/docs/CommandGuide/llvm-dwarfdump.rst b/llvm/docs/CommandGuide/llvm-dwarfdump.rst
index 27ad4226e6cf9..137830259eb64 100644
--- a/llvm/docs/CommandGuide/llvm-dwarfdump.rst
+++ b/llvm/docs/CommandGuide/llvm-dwarfdump.rst
@@ -83,7 +83,7 @@ OPTIONS
.. option:: -n <name>, --name=<name>
Find and print all debug info entries whose name
- (`DW_AT_name` attribute) is <name>.
+ (`DW_AT_name`/`DW_AT_linkage_name` attribute) is <name>.
.. option:: --lookup=<address>
diff --git a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
index 79f05278c329d..11eb58ea911df 100644
--- a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
+++ b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
@@ -202,9 +202,10 @@ static alias IgnoreCaseAlias("i", desc("Alias for --ignore-case."),
aliasopt(IgnoreCase), cl::NotHidden);
static list<std::string> Name(
"name",
- desc("Find and print all debug info entries whose name (DW_AT_name "
- "attribute) matches the exact text in <pattern>. When used with the "
- "the -regex option <pattern> is interpreted as a regular expression."),
+ desc("Find and print all debug info entries whose name "
+ "(DW_AT_name/DW_AT_linkage_name attribute) matches the exact text "
+ "in <pattern>. When used with the the -regex option <pattern> is "
+ "interpreted as a regular expression."),
value_desc("pattern"), cat(DwarfDumpCategory));
static alias NameAlias("n", desc("Alias for --name"), aliasopt(Name),
cl::NotHidden);
|
OCHyams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…m#164433) The `llvm-dwarfdump --name=<name>` option accepts `DW_AT_linkage_name` names too.
…m#164433) The `llvm-dwarfdump --name=<name>` option accepts `DW_AT_linkage_name` names too.
The
llvm-dwarfdump --name=<name>option acceptsDW_AT_linkage_namenames too.