[MLIR][ExecutionEngine] don't leak -Wweak-vtables #164498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not 100% what this is used for in this lib but the compile flag leaks out and prevents (in certain compile scenarios) linking `mlir_c_runner_utils`.
makslevental
requested review from
PeimingLiu,
aartbik,
matthias-springer and
yinying-lisa-li
as code owners
Member
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-sparse Author: Maksim Levental (makslevental) ChangesI'm not 100% what this is used for in this lib but the compile flag leaks out and prevents (in certain compile scenarios) linking Full diff: https://github.com/llvm/llvm-project/pull/164498.diff 1 Files Affected:
diff --git a/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt b/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt
index 6ef1529343453..c712c64b6de55 100644
--- a/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt
+++ b/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt
@@ -21,6 +21,6 @@ set_property(TARGET MLIRSparseTensorRuntime PROPERTY CXX_STANDARD 17)
check_cxx_compiler_flag(-Wweak-vtables
COMPILER_SUPPORTS_WARNING_WEAK_VTABLES)
if(COMPILER_SUPPORTS_WARNING_WEAK_VTABLES)
- target_compile_options(MLIRSparseTensorRuntime PUBLIC
+ target_compile_options(MLIRSparseTensorRuntime PRIVATE
"-Wweak-vtables")
endif()
|
Member
|
@llvm/pr-subscribers-mlir-execution-engine Author: Maksim Levental (makslevental) ChangesI'm not 100% what this is used for in this lib but the compile flag leaks out and prevents (in certain compile scenarios) linking Full diff: https://github.com/llvm/llvm-project/pull/164498.diff 1 Files Affected:
diff --git a/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt b/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt
index 6ef1529343453..c712c64b6de55 100644
--- a/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt
+++ b/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt
@@ -21,6 +21,6 @@ set_property(TARGET MLIRSparseTensorRuntime PROPERTY CXX_STANDARD 17)
check_cxx_compiler_flag(-Wweak-vtables
COMPILER_SUPPORTS_WARNING_WEAK_VTABLES)
if(COMPILER_SUPPORTS_WARNING_WEAK_VTABLES)
- target_compile_options(MLIRSparseTensorRuntime PUBLIC
+ target_compile_options(MLIRSparseTensorRuntime PRIVATE
"-Wweak-vtables")
endif()
|
matthias-springer
approved these changes
Oct 23, 2025
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
I'm not 100% what this is used for in this lib but the compile flag leaks out and prevents (in certain compile scenarios) linking `mlir_c_runner_utils`.
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
I'm not 100% what this is used for in this lib but the compile flag leaks out and prevents (in certain compile scenarios) linking `mlir_c_runner_utils`.
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
I'm not 100% what this is used for in this lib but the compile flag leaks out and prevents (in certain compile scenarios) linking `mlir_c_runner_utils`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% what this is used for in this lib but the compile flag leaks out and prevents (in certain compile scenarios) linking
mlir_c_runner_utils.