[MSan] Make Test work with Internal Shell #165144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7
llvmbot
added
compiler-rt
compiler-rt:msan
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Aiden Grossman (boomanaiden154) ChangesThis test used a subshell which is not supported by lit's internal Full diff: https://github.com/llvm/llvm-project/pull/165144.diff 1 Files Affected:
diff --git a/compiler-rt/test/msan/allocator_mapping.cpp b/compiler-rt/test/msan/allocator_mapping.cpp
index e7a12da489152..6eaba7e16a5be 100644
--- a/compiler-rt/test/msan/allocator_mapping.cpp
+++ b/compiler-rt/test/msan/allocator_mapping.cpp
@@ -3,7 +3,8 @@
// mapping the heap early, in __msan_init.
//
// RUN: %clangxx_msan -O0 %s -o %t_1
-// RUN: %clangxx_msan -O0 -DHEAP_ADDRESS=$(%run %t_1) %s -o %t_2 && %run %t_2
+// RUN: %run %t_1 > %t.heap_address
+// RUN: %clangxx_msan -O0 -DHEAP_ADDRESS=%{readfile:%t.heap_address} %s -o %t_2 && %run %t_2
//
// This test only makes sense for the 64-bit allocator. The 32-bit allocator
// does not have a fixed mapping. Exclude platforms that use the 32-bit
|
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 26, 2025
This test used a subshell which is not supported by lit's internal shell. Rewrite it to use the readfile substitution. Pull Request: llvm#165144
thurstond
approved these changes
Oct 27, 2025
fmayer
approved these changes
Oct 27, 2025
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 30, 2025
This test used a subshell which is not supported by lit's internal shell. Rewrite it to use the readfile substitution. Pull Request: llvm#165144
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 30, 2025
This test used a subshell which is not supported by lit's internal shell. Rewrite it to use the readfile substitution. Pull Request: llvm#165144
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 30, 2025
This test used a subshell which is not supported by lit's internal shell. Rewrite it to use the readfile substitution. Pull Request: llvm#165144
boomanaiden154
changed the base branch from
users/boomanaiden154/main.msan-make-test-work-with-internal-shell
to
main
boomanaiden154
deleted the
users/boomanaiden154/msan-make-test-work-with-internal-shell
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 30, 2025
This test used a subshell which is not supported by lit's internal shell. Rewrite it to use the readfile substitution. Reviewers: thurstond, fmayer Reviewed By: thurstond, fmayer Pull Request: llvm/llvm-project#165144
luciechoi
pushed a commit
to luciechoi/llvm-project
that referenced
this pull request
Nov 1, 2025
This test used a subshell which is not supported by lit's internal shell. Rewrite it to use the readfile substitution. Reviewers: thurstond, fmayer Reviewed By: thurstond, fmayer Pull Request: llvm#165144
DEBADRIBASAK
pushed a commit
to DEBADRIBASAK/llvm-project
that referenced
this pull request
Nov 3, 2025
This test used a subshell which is not supported by lit's internal shell. Rewrite it to use the readfile substitution. Reviewers: thurstond, fmayer Reviewed By: thurstond, fmayer Pull Request: llvm#165144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test used a subshell which is not supported by lit's internal
shell. Rewrite it to use the readfile substitution.