[libc][hdrgen] Fix includes sorting in JSON emission
#165460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON output support in hdrgen had a bug that tripped when used with headers that use special-case headers like <stdint.h> to supply some times, as well as llvm-libc-types/*.h headers.
Member
|
@llvm/pr-subscribers-libc Author: Roland McGrath (frobtech) ChangesThe JSON output support in hdrgen had a bug that tripped when Full diff: https://github.com/llvm/llvm-project/pull/165460.diff 1 Files Affected:
diff --git a/libc/utils/hdrgen/hdrgen/header.py b/libc/utils/hdrgen/hdrgen/header.py
index 2118db6e5fb75..967aa1fac5f22 100644
--- a/libc/utils/hdrgen/hdrgen/header.py
+++ b/libc/utils/hdrgen/hdrgen/header.py
@@ -241,7 +241,7 @@ def json_data(self):
return {
"name": self.name,
"standards": self.standards,
- "includes": [
- str(file) for file in sorted({COMMON_HEADER} | self.includes())
- ],
+ "includes": sorted(
+ str(file) for file in {COMMON_HEADER} | self.includes()
+ ),
}
|
|
✅ With the latest revision this PR passed the Python code formatter. |
PiJoules
approved these changes
Oct 28, 2025
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
The JSON output support in hdrgen had a bug that tripped when used with headers that use special-case headers like <stdint.h> to supply some times, as well as llvm-libc-types/*.h headers.
DEBADRIBASAK
pushed a commit
to DEBADRIBASAK/llvm-project
that referenced
this pull request
Nov 3, 2025
The JSON output support in hdrgen had a bug that tripped when used with headers that use special-case headers like <stdint.h> to supply some times, as well as llvm-libc-types/*.h headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON output support in hdrgen had a bug that tripped when
used with headers that use special-case headers like <stdint.h>
to supply some times, as well as llvm-libc-types/*.h headers.