LLDB DAP test failures after 17dbd869

[ilovepi]

We're seeing a number of lldb tests fail after 17dbd86 (note eec44c0 which landed along side it, seems unrelated, since we see these fail on x86_64 hosts).

Bot: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/lldb-linux-x64/b8699563123372506897/overview

Logs: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8699563123372506897/+/u/test_lldb/check_lldb/stdout

@DavidSpickett could you take a look?

[llvmbot]

@llvm/issue-subscribers-lldb-dap

Author: Paul Kirth (ilovepi)

We're seeing a number of lldb tests fail after 17dbd86 (note eec44c0 which landed along side it, seems unrelated, since we see these fail on x86_64 hosts).

Bot: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/lldb-linux-x64/b8699563123372506897/overview

Logs: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8699563123372506897/+/u/test_lldb/check_lldb/stdout

@DavidSpickett could you take a look?

[ilovepi]

also worth noting, we also see this fail on aarch64 hosts: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/lldb-linux-arm64/b8699557789109353713/overview

[JDevlieghere]

CC @ashgti

[ashgti]

During the teardown sequence it seems like we may not be receiving a closing " character in the JSON output.

TestDAP_stackTraceDisassemblyDisplay.TestDAP_stackTraceMissingSourcePath.test_stopDisassemblyDisplay)
======================================================================
ERROR: test_stopDisassemblyDisplay (TestDAP_stackTraceDisassemblyDisplay.TestDAP_stackTraceMissingSourcePath.test_stopDisassemblyDisplay)
   Test that with with all stop-disassembly-display values you get correct assembly / no assembly source code.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/s/w/ir/x/w/llvm-llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2066, in tearDown
    Base.tearDown(self)
  File "/b/s/w/ir/x/w/llvm-llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1106, in tearDown
    hook()  # try the plain call and hope it works
    ^^^^^^
  File "/b/s/w/ir/x/w/llvm-llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py", line 530, in cleanup
    self.dap_server.request_disconnect(terminateDebuggee=True)
  File "/b/s/w/ir/x/w/llvm-llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py", line 881, in request_disconnect
    return self._send_recv(command_dict)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/b/s/w/ir/x/w/llvm-llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py", line 498, in _send_recv
    response = self.receive_response(seq)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/b/s/w/ir/x/w/llvm-llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py", line 510, in receive_response
    return cast(Optional[Response], self._recv_packet(predicate=predicate))
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/b/s/w/ir/x/w/llvm-llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py", line 328, in _recv_packet
    packet = self._read_packet(timeout=deadline - time.time())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/b/s/w/ir/x/w/llvm-llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py", line 252, in _read_packet
    return json.loads(json_str)
           ^^^^^^^^^^^^^^^^^^^^
  File "/b/s/w/ir/x/w/install-cpython-x86_64-linux-gnu/lib/python3.11/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/b/s/w/ir/x/w/install-cpython-x86_64-linux-gnu/lib/python3.11/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/b/s/w/ir/x/w/install-cpython-x86_64-linux-gnu/lib/python3.11/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
               ^^^^^^^^^^^^^^^^^^^^^^
json.decoder.JSONDecodeError: Unterminated string starting at: line 1 column 8168 (char 8167)
Config=x86_64-/b/s/w/ir/x/w/cipd/clang/bin/clang
----------------------------------------------------------------------
Ran 1 test in 0.392s

FAILED (errors=1)

The tests on that bot have this stack trace at the end of almost all of the disconnect requests.

When lldb-dap terminates it reports some stats in the termination request that are rather large. I wonder if we're hitting a page boundary. We may need to check the length of the read and try it again. I'll take a look and see if thats related.

[DavidSpickett]

NameError: name 'skipif' is not defined. Did you mean: 'skipIf'?

These parts have been fixed.