Infinite recursion in the 'NVPTX Replace Image Handles' pass with `@llvm.nvvm.sust.b.2d.*` intrinsics

[Mike-Leo-Smith]

This issue can be reproduced in the Compiler Explorer: https://godbolt.org/z/qPGG1KvfE

[Mike-Leo-Smith]

I have reduced the IR into a minimal reproducible form:

; ModuleID = 'kernel_5cad7e6a3f2efa36'
target datalayout = "e-p6:32:32-i64:64-i128:128-v16:16-v32:32-n16:32:64"
target triple = "nvptx64-nvidia-cuda"

%kernel.params.struct = type { { i64, i64 }, <4 x i32> }

; Function Attrs: nounwind
define ptx_kernel void @kernel_main(%kernel.params.struct %0) {

entry:                                               ; preds = %alloca
  %1 = extractvalue %kernel.params.struct %0, 0
  %2 = extractvalue { i64, i64 } %1, 0
  tail call void @llvm.nvvm.sust.b.2d.v4i32.zero(i64 %2, i32 0, i32 0, i32 0, i32 0, i32 0, i32 0)
  br label %common.ret

common.ret:                                       ; preds = %alloca, %16
  ret void
}

; Function Attrs: nounwind
declare void @llvm.nvvm.sust.b.2d.v4i32.zero(i64, i32, i32, i32, i32, i32, i32)

Interestingly, if I change %kernel.params.struct to type { { i64, i64 }, [4 x i32] }, the program successfully compiles. So I guess there might be some deeper roots of the issue? Or is using vector types in the kernel argument simply disallowed?

[GrumpyPigSkin]

I had a look at this and the case that causes the crash are not handled in NVPTXReplaceImageHandles::replaceImageHandle, I can get the code to compile by simply adding the case NVPTX::LDV_i64_v2 is it also worth adding any other cases?

  case NVPTX::LDV_i64_v2: // Added
  case NVPTX::LD_i64: { // This is the path the array case [] takes
    // The handle is a parameter value being loaded, replace with the
    // parameter symbol
    const auto &TM = static_cast<const NVPTXTargetMachine &>(MF.getTarget());
    if (TM.getDrvInterface() == NVPTX::CUDA)
      // For CUDA, we preserve the param loads coming from function arguments
      return false; 

    assert(TexHandleDef.getOperand(6).isSymbol() && "Load is not a symbol!");
    StringRef Sym = TexHandleDef.getOperand(6).getSymbolName();
    InstrsToRemove.insert(&TexHandleDef);
    Op.ChangeToES(Sym.data());
    MFI->getImageHandleSymbolIndex(Sym);
    return true;
  }

Let me know if this is the correct action and I will happily make the change :)