Missing changes for WG14 N3622

[AaronBallman]

8e60adc implemented part of the paper, but missed "shall not contain a definition of a modifiable object with static or thread storage duration" from the removed text. e.g., we still diagnose this:

inline void f(void) {
  static int x; // warning: on-constant static local variable in inline function may be different in different files
}

https://godbolt.org/z/PhK6YvYnP

This should be accepted in C2y mode and claimed as an extension in earlier language modes.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Aaron Ballman (AaronBallman)

8e60adc implemented part of the paper, but missed "shall not contain a definition of a modifiable object with static or thread storage duration" from the removed text. e.g., we still diagnose this: ``` inline void f(void) { static int x; // warning: on-constant static local variable in inline function may be different in different files } ``` https://godbolt.org/z/PhK6YvYnP

This should be accepted in C2y mode and claimed as an extension in earlier language modes.

[AaronBallman]

I think this may be a good first issue. Basically, we need changes similar to the linked commit, but for warn_static_local_in_extern_inline

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor is working on this issue. If someone is assigned to the issue or claimed to be working on it, ping the person. After one week without a response, the assignee may be changed.
2. Leave a comment indicating that you are working on the issue, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Aaron Ballman (AaronBallman)

8e60adc implemented part of the paper, but missed "shall not contain a definition of a modifiable object with static or thread storage duration" from the removed text. e.g., we still diagnose this: ``` inline void f(void) { static int x; // warning: on-constant static local variable in inline function may be different in different files } ``` https://godbolt.org/z/PhK6YvYnP

This should be accepted in C2y mode and claimed as an extension in earlier language modes.

[Pranjal095]

Hi, I'd be delighted to work on this issue. I'll refer to the linked commit and ensure the required functionality is implemented.