clang-format: Allow empty records on a single line

[daggerbot]

Feel free to close this if this is already possible and I just failed to figure out how.

There doesn't appear to be a way to accomplish this with clang-format:

// Break before braces after class/struct/union:
struct Foo
{
  int x;
};

// AND allow empty class/struct/union on a single line:
struct Foo {};

If we set BraceWrapping: AfterStruct: true and BraceWrapping: SplitEmptyRecord: false, we instead get this:

struct Foo
{};

My proposal would be to add a bool AllowEmptyRecordsOnASingleLine option that handles this case similarly to the AllowShortEnumsOnASingleLine option. If others think this would be an acceptable enhancement, I can look into implementing it myself, but I thought I'd request feedback before I put in the work.

[llvmbot]

@llvm/issue-subscribers-clang-format

Author: Martin Mills (daggerbot)

Feel free to close this if this is already possible and I just failed to figure out how.

There doesn't appear to be a way to accomplish this with clang-format:

// Break before braces after class/struct/union:
struct Foo
{
  int x;
};

// AND allow empty class/struct/union on a single line:
struct Foo {};

If we set BraceWrapping: AfterStruct: true and BraceWrapping: SplitEmptyRecord: false, we instead get this:

struct Foo
{};

My proposal would have two parts:

• Add a bool AllowEmptyRecordsOnASingleLine option to handle the case in this example, and
• Change the type of AllowShortEnumsOnASingleLine to have Yes, No, and Empty values (while allowing true or false for backwards compatibility if possible) to allow the same behavior for empty enums but not short, non-empty enums.

If others think this would be an acceptable enhancement, I can look into implementing it myself, but I though I'd request feedback before I put in the work.

[triplejam]

It's not possible yet. #53960

I don't know what their problem is with Allman braces. Educators literally use them because they are easier to read. But who in their mind thinks

struct Foo
{
};

struct Bar
{
};

struct Spam
{
};

struct Eggs
{
};

is what somebody wants is beyond me.

[owenca]

There's already a pull request #154580 for this.