benchmarks: Fix sample_symbol_list.txt generation again #167078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
added
the
cmake
Graphite App
s-barannikov
reviewed
Nov 8, 2025
llvm/benchmarks/CMakeLists.txt
Outdated
| # Extract the list of symbols in a random utility as sample data. | ||
| set(SYMBOL_TEST_DATA_FILE "sample_symbol_list.txt") | ||
| set(SYMBOL_TEST_DATA_SOURCE_BINARY ${llc_exe}) | ||
| if(TARGET ${llc_target}) |
Contributor
There was a problem hiding this comment.
Since last review I learned that if argument shouldn't use ${} syntax, otherwice it may be expanded twice (if the first expansion yields a name of existing cmake variable). This requires the variable to always have some value though, otherwise it willbe treated as target name.
Perhaps if (TARGET "${llc_target}" AND TARGET "${llvm_nm_target}") would also work.
This wasn't triggering on a basic build. The various target checks seem to not work as I expect with AND, so split this into separate if TARGET checks.
arsenm
force-pushed
the
users/arsenm/benchmarks/fix-runtime-libcalls-bench-build
branch
from
841582e to
d66b4a9
Compare
s-barannikov
approved these changes
Nov 8, 2025
Contributor
s-barannikov
left a comment
s-barannikov
left a comment
There was a problem hiding this comment.
LGTM as long as it works
arsenm
deleted the
users/arsenm/benchmarks/fix-runtime-libcalls-bench-build
branch
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/16844 Here is the relevant piece of the build log for the reference |
vinay-deshmukh
pushed a commit
to vinay-deshmukh/llvm-project
that referenced
this pull request
Nov 8, 2025
This wasn't triggering on a basic build
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/127/builds/5239 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't triggering on a basic build. The various target checks
seem to not work as I expect with AND, so split this into separate
if TARGET checks.