DAG: Use poison in SplitVecRes_VP_LOAD_FF #167753
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
added
backend:AArch64
backend:ARM
backend:RISC-V
backend:X86
llvm:SelectionDAG
Graphite App
arsenm
requested review from
RKSimon,
bjope,
lukel97,
mshockwave and
preames
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
|
@llvm/pr-subscribers-llvm-selectiondag @llvm/pr-subscribers-backend-aarch64 Author: Matt Arsenault (arsenm) ChangesFull diff: https://github.com/llvm/llvm-project/pull/167753.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
index 461cea2e80748..417122d467054 100644
--- a/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
@@ -2363,7 +2363,7 @@ void DAGTypeLegalizer::SplitVecRes_VP_LOAD_FF(VPLoadFFSDNode *LD, SDValue &Lo,
Lo = DAG.getLoadFFVP(LoVT, dl, Ch, Ptr, MaskLo, EVLLo, MMO);
// Fill the upper half with poison.
- Hi = DAG.getUNDEF(HiVT);
+ Hi = DAG.getPOISON(HiVT);
ReplaceValueWith(SDValue(LD, 1), Lo.getValue(1));
ReplaceValueWith(SDValue(LD, 2), Lo.getValue(2));
|
Member
|
@llvm/pr-subscribers-backend-risc-v Author: Matt Arsenault (arsenm) ChangesFull diff: https://github.com/llvm/llvm-project/pull/167753.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
index 461cea2e80748..417122d467054 100644
--- a/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
@@ -2363,7 +2363,7 @@ void DAGTypeLegalizer::SplitVecRes_VP_LOAD_FF(VPLoadFFSDNode *LD, SDValue &Lo,
Lo = DAG.getLoadFFVP(LoVT, dl, Ch, Ptr, MaskLo, EVLLo, MMO);
// Fill the upper half with poison.
- Hi = DAG.getUNDEF(HiVT);
+ Hi = DAG.getPOISON(HiVT);
ReplaceValueWith(SDValue(LD, 1), Lo.getValue(1));
ReplaceValueWith(SDValue(LD, 2), Lo.getValue(2));
|
Member
|
@llvm/pr-subscribers-backend-arm Author: Matt Arsenault (arsenm) ChangesFull diff: https://github.com/llvm/llvm-project/pull/167753.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
index 461cea2e80748..417122d467054 100644
--- a/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
@@ -2363,7 +2363,7 @@ void DAGTypeLegalizer::SplitVecRes_VP_LOAD_FF(VPLoadFFSDNode *LD, SDValue &Lo,
Lo = DAG.getLoadFFVP(LoVT, dl, Ch, Ptr, MaskLo, EVLLo, MMO);
// Fill the upper half with poison.
- Hi = DAG.getUNDEF(HiVT);
+ Hi = DAG.getPOISON(HiVT);
ReplaceValueWith(SDValue(LD, 1), Lo.getValue(1));
ReplaceValueWith(SDValue(LD, 2), Lo.getValue(2));
|
arsenm
force-pushed
the
users/arsenm/dag/use-poison-split-vec-res-vp-load-ff
branch
from
71b6ed5 to
d18eeae
Compare
arsenm
force-pushed
the
users/arsenm/dag/poison-scalar-to-vector-result-widen
branch
from
3653a95 to
2466334
Compare
RKSimon
approved these changes
Nov 13, 2025
Base automatically changed from
users/arsenm/dag/poison-scalar-to-vector-result-widen
to
main
November 15, 2025 16:47
arsenm
deleted the
users/arsenm/dag/use-poison-split-vec-res-vp-load-ff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.