[lldb] Fix command line of target frame-provider register

[vogelsgesang]

So far, the syntax was target frame-provider register <cmd-options> [<run-args>]. Note the optional run-args at the end. They are completely ignored by the actual command, but the command line parser still accepts them.

This commit removes them.

This was probably a copy-paste error from CommandObjectProcessLaunch which was probably used as a blue-print for target frame-provider register.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Adrian Vogelsgesang (vogelsgesang)

Changes

So far, the syntax was
> target frame-provider register <cmd-options> [<run-args>]

Note the optional run-args at the end. They are completely ignored by the actual command, but the command line parser still accepts them. This commit removes them.

They were probably a copy-paste error from CommandObjectProcessLaunch which was probably used as a blue-print for target frame-provider register.

---

Full diff: https://github.com/llvm/llvm-project/pull/167803.diff

1 Files Affected:

• (modified) lldb/source/Commands/CommandObjectTarget.cpp (+1-3)

diff --git a/lldb/source/Commands/CommandObjectTarget.cpp b/lldb/source/Commands/CommandObjectTarget.cpp
index 86373f5280271..e019264cafda3 100644
--- a/lldb/source/Commands/CommandObjectTarget.cpp
+++ b/lldb/source/Commands/CommandObjectTarget.cpp
@@ -5419,8 +5419,6 @@ class CommandObjectTargetFrameProviderRegister : public CommandObjectParsed {
     m_all_options.Append(&m_class_options, LLDB_OPT_SET_1 | LLDB_OPT_SET_2,
                          LLDB_OPT_SET_ALL);
     m_all_options.Finalize();
-
-    AddSimpleArgumentList(eArgTypeRunArgs, eArgRepeatOptional);
   }
 
   ~CommandObjectTargetFrameProviderRegister() override = default;
@@ -5433,7 +5431,7 @@ class CommandObjectTargetFrameProviderRegister : public CommandObjectParsed {
   }
 
 protected:
-  void DoExecute(Args &launch_args, CommandReturnObject &result) override {
+  void DoExecute(Args &command, CommandReturnObject &result) override {
     ScriptedMetadataSP metadata_sp = std::make_shared<ScriptedMetadata>(
         m_class_options.GetName(), m_class_options.GetStructuredData());
 

[jimingham]

LGTM

[medismailben]

Thanks!