Skip to content

Conversation

@boomanaiden154
Copy link
Contributor

To fix the TODO now that the ninja version available in the Ubuntu repositories (1.11) is new enough.

To fix the TODO now that the ninja version available in the Ubuntu
repositories (1.11) is new enough.
@boomanaiden154 boomanaiden154 requested a review from a team as a code owner November 15, 2025 18:46
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Nov 15, 2025
@llvmbot
Copy link
Member

llvmbot commented Nov 15, 2025

@llvm/pr-subscribers-libcxx

Author: Aiden Grossman (boomanaiden154)

Changes

To fix the TODO now that the ninja version available in the Ubuntu repositories (1.11) is new enough.


Full diff: https://github.com/llvm/llvm-project/pull/168225.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/docker/linux-builder-base.dockerfile (+1-8)
diff --git a/libcxx/utils/ci/docker/linux-builder-base.dockerfile b/libcxx/utils/ci/docker/linux-builder-base.dockerfile
index af09f15a72747..8a8a6e3888cbb 100644
--- a/libcxx/utils/ci/docker/linux-builder-base.dockerfile
+++ b/libcxx/utils/ci/docker/linux-builder-base.dockerfile
@@ -70,6 +70,7 @@ RUN sudo apt-get update \
         libxml2-dev \
         lsb-release \
         make \
+        ninja-build \
         python3 \
         python3-dev \
         python3-packaging \
@@ -83,14 +84,6 @@ RUN sudo apt-get update \
         xz-utils \
     && sudo rm -rf /var/lib/apt/lists/*
 
-RUN <<EOF
-  set -e
-  wget -qO /tmp/ninja.gz https://github.com/ninja-build/ninja/releases/latest/download/ninja-linux.zip
-  gunzip /tmp/ninja.gz
-  chmod a+x /tmp/ninja
-  sudo mv /tmp/ninja /usr/local/bin/ninja
-EOF
-
 # These two locales are not enabled by default so generate them
 RUN <<EOF
   set -e

@zwuis zwuis changed the title [libxx] Install ninja in CI container from system repo [libcxx] Install ninja in CI container from system repo Nov 16, 2025
@boomanaiden154 boomanaiden154 merged commit 789ef89 into llvm:main Nov 16, 2025
83 checks passed
@boomanaiden154 boomanaiden154 deleted the install-ninja-system-11-15-25 branch November 16, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants