-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[compiler-rt] [test] Avoid error printouts if os.sysconf is missing #168857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🐧 Linux x64 Test Results
|
|
Wouldn't it be better to just fix the offending script to not use sysconf on Windows? |
I guess that could work as well, although the script being inline in the |
how about this? |
This avoids dozens of instances of benign error messages being
printed when running the tests on e.g. Windows:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: module 'os' has no attribute 'sysconf'
18c7fc6 to
52d9d82
Compare
Thanks, that seems to work! I've updated the PR with that. |
|
✅ With the latest revision this PR passed the Python code formatter. |
fmayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I like that much better
please fix formatting
…lvm#168857) This avoids dozens of instances of benign error messages being printed when running the tests on e.g. Windows: Traceback (most recent call last): File "<stdin>", line 1, in <module> AttributeError: module 'os' has no attribute 'sysconf' Co-authored-by: Florian Mayer <[email protected]>
This avoids dozens of instances of benign error messages being printed when running the tests on e.g. Windows: