Skip to content

Conversation

@jdenny-ornl
Copy link
Collaborator

The test was added by b8ef25a. It failed on at least the following bots, but the failure did not reproduce on my test machines or in pre-commit CI:

This fix hopefully addresses at least the warnings there.

The test was added by b8ef25a.  It
failed on at least the following bots, but the failure did not
reproduce on my test machines or in pre-commit CI:

- https://lab.llvm.org/buildbot/#/builders/190/builds/31638
- https://lab.llvm.org/buildbot/#/builders/190/builds/31638

This fix hopefully addresses at least the warnings there.
@jdenny-ornl jdenny-ornl merged commit d69e701 into main Nov 25, 2025
9 of 12 checks passed
@jdenny-ornl jdenny-ornl deleted the users/jdenny-ornl/pr-167792-fixup branch November 25, 2025 16:42
@llvmbot
Copy link
Member

llvmbot commented Nov 25, 2025

@llvm/pr-subscribers-llvm-transforms

Author: Joel E. Denny (jdenny-ornl)

Changes

The test was added by b8ef25a. It failed on at least the following bots, but the failure did not reproduce on my test machines or in pre-commit CI:

This fix hopefully addresses at least the warnings there.


Full diff: https://github.com/llvm/llvm-project/pull/169520.diff

1 Files Affected:

  • (modified) llvm/test/Transforms/LoopVectorize/vectorize-zero-estimated-trip-count.ll (+1)
diff --git a/llvm/test/Transforms/LoopVectorize/vectorize-zero-estimated-trip-count.ll b/llvm/test/Transforms/LoopVectorize/vectorize-zero-estimated-trip-count.ll
index 436324b4bab7a..c91a764681d20 100644
--- a/llvm/test/Transforms/LoopVectorize/vectorize-zero-estimated-trip-count.ll
+++ b/llvm/test/Transforms/LoopVectorize/vectorize-zero-estimated-trip-count.ll
@@ -4,6 +4,7 @@
 
 ; RUN: opt -passes=loop-vectorize -S %s | FileCheck %s
 
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-unknown-linux-gnu"
 
 ; Look for basic signs that vectorization ran and produced memory checks.

@dyung
Copy link
Collaborator

dyung commented Nov 25, 2025

I think the problem is that at least on https://lab.llvm.org/buildbot/#/builders/190/builds/31643 the x86 backend is not built so you might need a REQUIRES lines.

@jdenny-ornl
Copy link
Collaborator Author

Thanks. I'll try that. There are other loop-vectorize tests (pr30806.ll pr35743.ll pr38697.ll) in the same directory that target x86_64 and do not have such a REQUIRES line, but perhaps the transformation somehow doesn't require the backend in their cases.

@jdenny-ornl
Copy link
Collaborator Author

Did so in PR #169531.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants