Skip to content

Conversation

@maksfb
Copy link
Contributor

@maksfb maksfb commented Nov 25, 2025

Enabling AT&T syntax for all tests is broken when X86 target is not enabled as reported in #167225.

Enabling AT&T syntax for all tests is broken when X86 target is not
enabled as reported in llvm#167225.
@llvmbot
Copy link
Member

llvmbot commented Nov 25, 2025

@llvm/pr-subscribers-bolt

Author: Maksim Panchenko (maksfb)

Changes

Enabling AT&T syntax for all tests is broken when X86 target is not enabled as reported in #167225.


Full diff: https://github.com/llvm/llvm-project/pull/169541.diff

2 Files Affected:

  • (modified) bolt/test/X86/lit.local.cfg (+1-1)
  • (modified) bolt/test/lit.local.cfg (+1-1)
diff --git a/bolt/test/X86/lit.local.cfg b/bolt/test/X86/lit.local.cfg
index ea9928d191884..680ebdd1eb6bf 100644
--- a/bolt/test/X86/lit.local.cfg
+++ b/bolt/test/X86/lit.local.cfg
@@ -1,7 +1,7 @@
 if not "X86" in config.root.targets:
     config.unsupported = True
 
-flags = "--target=x86_64-unknown-linux-gnu -nostdlib"
+flags = "--target=x86_64-unknown-linux-gnu -nostdlib -mllvm -x86-asm-syntax=att"
 
 config.substitutions.insert(0, ("%cflags", f"%cflags {flags}"))
 config.substitutions.insert(0, ("%cxxflags", f"%cxxflags {flags}"))
diff --git a/bolt/test/lit.local.cfg b/bolt/test/lit.local.cfg
index 78cc73e53b680..8a61d11f5825f 100644
--- a/bolt/test/lit.local.cfg
+++ b/bolt/test/lit.local.cfg
@@ -5,7 +5,7 @@ if not "linux" in host_triple:
   host_triple = host_triple.split("-")[0] + "-unknown-linux-gnu"
 
 common_linker_flags = "-fuse-ld=lld -Wl,--unresolved-symbols=ignore-all -Wl,--build-id=none -pie"
-flags = f"--target={host_triple} -fPIE {common_linker_flags} -mllvm -x86-asm-syntax=att"
+flags = f"--target={host_triple} -fPIE {common_linker_flags}"
 
 config.substitutions.insert(0, ("%cflags", f"%cflags {flags}"))
 config.substitutions.insert(0, ("%cxxflags", f"%cxxflags {flags}"))

@maksfb maksfb merged commit 6c48fbc into llvm:main Nov 25, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants