Skip to content

Conversation

@googlewalt
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Nov 25, 2025

@llvm/pr-subscribers-backend-nvptx

Author: Walter Lee (googlewalt)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/169542.diff

1 Files Affected:

  • (modified) llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp (+1-1)
diff --git a/llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp b/llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
index f3a3bc785d997..8b72b1e1f3a52 100644
--- a/llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
+++ b/llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
@@ -3457,7 +3457,7 @@ convertMLOADToLoadWithUsedBytesMask(MemSDNode *N, SelectionDAG &DAG) {
   SDValue Chain = N->getOperand(0);
   SDValue BasePtr = N->getOperand(1);
   SDValue Mask = N->getOperand(3);
-  SDValue Passthru = N->getOperand(4);
+  [[maybe_unused]] SDValue Passthru = N->getOperand(4);
 
   SDLoc DL(N);
   EVT ResVT = N->getValueType(0);

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title seems to mention the wrong commit?

1a03673 does not touch NVPTXISelLowering.

@boomanaiden154 boomanaiden154 changed the title Fix maybe unused variable in 1a036732d210 [NVPTX] Fix maybe unused variable in 17852deda7fb9dabb41023e2673025c630b9369d Nov 25, 2025
@boomanaiden154 boomanaiden154 changed the title [NVPTX] Fix maybe unused variable in 17852deda7fb9dabb41023e2673025c630b9369d [NVPTX] Fix maybe unused variable in 17852ded Nov 25, 2025
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the commit title with the correct one.

@googlewalt
Copy link
Contributor Author

I updated the commit title with the correct one.

Thanks!

@googlewalt googlewalt enabled auto-merge (squash) November 25, 2025 18:19
@googlewalt googlewalt merged commit 6c8ff4f into llvm:main Nov 25, 2025
9 of 11 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Nov 25, 2025

LLVM Buildbot has detected a new failure on builder clangd-ubuntu-tsan running on clangd-ubuntu-clang while building llvm at step 6 "test-build-clangd-clangd-index-server-clangd-in...".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/134/builds/30442

Here is the relevant piece of the build log for the reference
Step 6 (test-build-clangd-clangd-index-server-clangd-in...) failure: test (failure)
******************** TEST 'Clangd :: initialize-params.test' FAILED ********************
Exit Code: 66

Command Output (stderr):
--
clangd -lit-test < /vol/worker/clangd-ubuntu-clang/clangd-ubuntu-tsan/llvm-project/clang-tools-extra/clangd/test/initialize-params.test | /vol/worker/clangd-ubuntu-clang/clangd-ubuntu-tsan/build/bin/FileCheck -strict-whitespace /vol/worker/clangd-ubuntu-clang/clangd-ubuntu-tsan/llvm-project/clang-tools-extra/clangd/test/initialize-params.test # RUN: at line 1
+ clangd -lit-test
+ /vol/worker/clangd-ubuntu-clang/clangd-ubuntu-tsan/build/bin/FileCheck -strict-whitespace /vol/worker/clangd-ubuntu-clang/clangd-ubuntu-tsan/llvm-project/clang-tools-extra/clangd/test/initialize-params.test
WARNING: ThreadSanitizer: unexpected memory mapping 0x79fffef72000-0x79ffff400000
FATAL: ThreadSanitizer: unexpectedly found incompatible memory layout.
FATAL: Please file a bug.
I[18:43:00.196] clangd version 22.0.0git (https://github.com/llvm/llvm-project.git 6c8ff4f2bbae6fe29b0ef67edb70e6d73b47beb3)
I[18:43:00.196] Features: linux+debug+tsan+grpc
I[18:43:00.196] PID: 339624
I[18:43:00.196] Working directory: /vol/worker/clangd-ubuntu-clang/clangd-ubuntu-tsan/build/tools/clang/tools/extra/clangd/test
I[18:43:00.196] argv[0]: clangd
I[18:43:00.196] argv[1]: -lit-test
I[18:43:00.196] Starting LSP over stdin/stdout
V[18:43:00.197] <<< {
  "id": 0,
  "jsonrpc": "2.0",
  "method": "initialize",
  "params": {
    "capabilities": {},
    "processId": 123,
    "rootUri": "test:///workspace",
    "trace": "off"
  }
}

I[18:43:00.197] <-- initialize(0)
I[18:43:00.198] --> reply:initialize(0) 1 ms

--

********************


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants