[AMDGPU] Emit amdgpu.max_num_named_barrier resource symbol #169851
Merged
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
@llvm/pr-subscribers-backend-amdgpu Author: None (PMylon) ChangesEmit Full diff: https://github.com/llvm/llvm-project/pull/169851.diff 3 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp b/llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
index 33cef795b111d..270154452f6df 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
@@ -536,7 +536,8 @@ bool AMDGPUAsmPrinter::doFinalization(Module &M) {
OutStreamer->switchSection(MaxGPRSection);
getTargetStreamer()->EmitMCResourceMaximums(RI.getMaxVGPRSymbol(OutContext),
RI.getMaxAGPRSymbol(OutContext),
- RI.getMaxSGPRSymbol(OutContext));
+ RI.getMaxSGPRSymbol(OutContext),
+ RI.getMaxNamedBarrierSymbol(OutContext));
OutStreamer->popSection();
for (Function &F : M.functions())
diff --git a/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp b/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
index 5a0857322a39b..b12b6ed441659 100644
--- a/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
+++ b/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
@@ -304,7 +304,8 @@ void AMDGPUTargetAsmStreamer::EmitMCResourceInfo(
void AMDGPUTargetAsmStreamer::EmitMCResourceMaximums(const MCSymbol *MaxVGPR,
const MCSymbol *MaxAGPR,
- const MCSymbol *MaxSGPR) {
+ const MCSymbol *MaxSGPR,
+ const MCSymbol *MaxNamedBarrier) {
#define PRINT_RES_INFO(ARG) \
OS << "\t.set "; \
ARG->print(OS, getContext().getAsmInfo()); \
@@ -315,6 +316,7 @@ void AMDGPUTargetAsmStreamer::EmitMCResourceMaximums(const MCSymbol *MaxVGPR,
PRINT_RES_INFO(MaxVGPR);
PRINT_RES_INFO(MaxAGPR);
PRINT_RES_INFO(MaxSGPR);
+ PRINT_RES_INFO(MaxNamedBarrier);
#undef PRINT_RES_INFO
}
diff --git a/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h b/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h
index 22afcdebcdf09..3a0d8dcd2d27c 100644
--- a/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h
+++ b/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h
@@ -69,7 +69,8 @@ class AMDGPUTargetStreamer : public MCTargetStreamer {
virtual void EmitMCResourceMaximums(const MCSymbol *MaxVGPR,
const MCSymbol *MaxAGPR,
- const MCSymbol *MaxSGPR) {};
+ const MCSymbol *MaxSGPR,
+ const MCSymbol *MaxNamedBarrier) {};
/// \returns True on success, false on failure.
virtual bool EmitISAVersion() { return true; }
@@ -149,7 +150,8 @@ class AMDGPUTargetAsmStreamer final : public AMDGPUTargetStreamer {
const MCSymbol *HasRecursion, const MCSymbol *HasIndirectCall) override;
void EmitMCResourceMaximums(const MCSymbol *MaxVGPR, const MCSymbol *MaxAGPR,
- const MCSymbol *MaxSGPR) override;
+ const MCSymbol *MaxSGPR,
+ const MCSymbol *MaxNamedBarrier) override;
/// \returns True on success, false on failure.
bool EmitISAVersion() override;
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Contributor
Author
antiagainst
added a commit
to triton-lang/triton
that referenced
this pull request
Dec 4, 2025
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/129/builds/34393 Here is the relevant piece of the build log for the reference |
antiagainst
added a commit
to antiagainst/triton
that referenced
this pull request
Dec 6, 2025
This pulls in the following fixes: * llvm/llvm-project#168801 * llvm/llvm-project#168805 * llvm/llvm-project#169851 Along the way, we need to adjust `TMEMLoadOpPattern` and `RelayoutTritonGPU` due to * llvm/llvm-project#169606
antiagainst
added a commit
to triton-lang/triton
that referenced
this pull request
Dec 8, 2025
This pulls in the following fixes: * llvm/llvm-project#168801 * llvm/llvm-project#168805 * llvm/llvm-project#169851 Along the way, we need to adjust `TMEMLoadOpPattern` and `RelayoutTritonGPU` due to * llvm/llvm-project#169606
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
ThomasRaoux
pushed a commit
to triton-lang/triton
that referenced
this pull request
Dec 12, 2025
This pulls in the following fixes: * llvm/llvm-project#168801 * llvm/llvm-project#168805 * llvm/llvm-project#169851 Along the way, we need to adjust `TMEMLoadOpPattern` and `RelayoutTritonGPU` due to * llvm/llvm-project#169606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit
amdgpu.max_num_named_barrierresource symbol which is referenced byamdgcn.device.init.num_named_barrier, max(0, amdgpu.max_num_named_barrier). FixesLLVM ERROR: cannot evaluate equated symbol 'amdgcn.device.init.num_named_barrier'when using ASan.