Wrong source location for friend static method

[Abramo-Bagnara]

Bugzilla Link	22461
Version	trunk
OS	Linux
CC	@DougGregor

Extended Description

For the following program:

struct A {
  template <typename T, typename U> static void create (U) {}
};

struct B {
  friend void A::create <B, const char *> (const char *);
};

int main() {
  A::create<B>("test");
}

I get this AST for friend declaration:

| `-FriendDecl 0x7f801d0 <line:2:37, col:61> line:6:18
|   `-CXXMethodDecl 0x7f7fc90 parent 0x7f3a0e0 prev 0x7f80000 <line:2:37, col:61> line:6:18 used create 'void (const char *)'
|     |-TemplateArgument type 'struct B'
|     |-TemplateArgument type 'const char *'
|     |-ParmVarDecl 0x7f7fbd0 <col:44, col:55> col:56 'const char *'
|     `-CompoundStmt 0x7f7f988 <line:2:60, col:61>

As can be observed from the dump above the friend method AST is not tied to source but it is a reference to instantiated method.

As a consequence the body is present and locations refers the templated function and not the friend method declaration.

[Endilll]

Still there in Clang 21.0: https://godbolt.org/z/cGbxcbK55

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: None (Abramo-Bagnara)

| | | | --- | --- | | Bugzilla Link | [22461](https://llvm.org/bz22461) | | Version | trunk | | OS | Linux | | CC | @DougGregor |

Extended Description

For the following program:

struct A {
  template <typename T, typename U> static void create (U) {}
};

struct B {
  friend void A::create <B, const char *> (const char *);
};

int main() {
  A::create<B>("test");
}

I get this AST for friend declaration:

| `-FriendDecl 0x7f801d0 <line:2:37, col:61> line:6:18
|   `-CXXMethodDecl 0x7f7fc90 parent 0x7f3a0e0 prev 0x7f80000 <line:2:37, col:61> line:6:18 used create 'void (const char *)'
|     |-TemplateArgument type 'struct B'
|     |-TemplateArgument type 'const char *'
|     |-ParmVarDecl 0x7f7fbd0 <col:44, col:55> col:56 'const char *'
|     `-CompoundStmt 0x7f7f988 <line:2:60, col:61>

As can be observed from the dump above the friend method AST is not tied to source but it is a reference to instantiated method.

As a consequence the body is present and locations refers the templated function and not the friend method declaration.