proper indention for goto destination point

[llvmbot]

Bugzilla Link	24118
Version	trunk
OS	Linux
Reporter	LLVM Bugzilla Contributor
CC	@mitchblank,@tromey

Extended Description

When using clang format based on google style.

It reformat the following code to

int main() {
  for (int i = 1; i < 10; i++)
    for (int j = 0; j < 5; j++) {
      // do something
      goto end_double_loop;
    }
end_double_loop : {}

  return 0;
}

Could someone add a clang format style options so the "end_double_loop" will be aligned to the first for loop instead of int main? Meaning the desired format is

int main() {
  for (int i = 1; i < 10; i++)
    for (int j = 0; j < 5; j++) {
      // do something
      goto end_double_loop;
    }
  end_double_loop : {}

  return 0;
}

Thanks,
Jason

[mitchblank]

I'd also like better control over this. In my personal code I put labels on their own line a HALF indent back to make them stick out a bit:

int foo()
{
    /* ... */
    goto label;

    /* ... */
    abc();
  label:
    xyz();
}

...but I don't think there's a way to make clang-format do that, either.

[llvmbot]

Yeah, our handling of goto labels isn't ideal.

That being said, I am not aware of major codebases using them enough to be worth spending time on it. If you (or someone else) wants to provide a patch, I am very happy to review it, but otherwise, I don't see any of the existing contributors working on this any time soon.

[tromey]

I'd also like better control over this. In my personal code I put labels on
their own line a HALF indent back to make them stick out a bit:

FWIW this is typical in the GNU style as well.
This is one of the issues we found trying to use
clang-format on gdb.

[mydeveloperday]

I confirm this is still an issue in clang-format v13

[varshneydevansh]

Can I pick this issue? Since I am beginning my learning all over again and recently used clang-format in another open-source project. @MacDue

[Endilll]

@varshneydevansh Sure!

[varshneydevansh]

Hi @Endilll do I have to start working from the directory https://github.com/llvm/llvm-project/tree/main/clang

clang/lib/Format

[Endilll]

Yes, that's where Clang subproject lives.