Comment tag is not properly created.

[llvmbot]

Bugzilla Link	33949
Version	trunk
OS	Windows NT
Reporter	LLVM Bugzilla Contributor
CC	@DougGregor

Extended Description

In my attempt to create a comment in cpp, and specifically this one https://github.com/glfw/glfw/blob/8e899ccc29cc082f8d373718f1881ef5b8863f84/include/GLFW/glfw3.h#L2307 I noticed that the generated tag was split into half with @thread to be the actual tag and _safety to be part of the text in the comment. I would expect clang to detect those type of tags and not terminate the key in _. For any detail please feel free to contact me at kimon.topouzidis@gmail.com

Best regards,
Topouzidis Kimon

[AaronBallman]

This reproduces as of Clang 20: https://godbolt.org/z/qKxxf3GqG

    |-ParagraphComment <line:19:3, col:74>
    | |-TextComment <col:3, col:4> Text="  "
    | |-InlineCommandComment <col:5, col:11> Name="thread" RenderNormal
    | `-TextComment <col:12, col:74> Text="_safety This function must only be called from the main thread."

[evelez7]

I don't think this is actually a clang-doc bug. The comment lexer stops lexing the command name when it encounters the first non-alphanumeric character, see:

llvm-project/clang/lib/AST/CommentLexer.cpp

Line 220 in 2a19efe

const char *skipCommandName(const char *BufferPtr, const char *BufferEnd) {

.

"thread" is taken as the command and the rest is assumed to be the comment. Maybe the command name should stop being lexed when the first whitespace is encountered?

[mdenson]

I'm new but interested in this project and would love to help. This one is really old, so not sure if no one cares, or if it needs different attention since it is not specific to clang-doc anymore. I've got something trivial and along the line of @evelez7 suggestion, stopping at the next whitespace. This seems to match doxygen from what I can tell, but with alias, they can essentially name commands anything. If you're interested, I'll submit it after I read up on 'Contributing to LLVM' and figure out how to write tests.