Aligning consecutive assignments in enum blocks only

[Julien-Elie]

Could it be possible to have an option to align assignments in enum blocks?

For instance:

enum nntp_code {
    NNTP_INFO_HELP         = 100,
    NNTP_INFO_CAPABILITIES = 101,
    NNTP_INFO_DATE         = 111,
    NNTP_OK_BANNER_POST    = 200,
    NNTP_OK_BANNER_NOPOST  = 201,
    NNTP_OK_QUIT           = 205,
    NNTP_OK_COMPRESS       = 206,
    NNTP_OK_GROUP          = 211,
    NNTP_OK_LIST           = 215,
    NNTP_OK_ARTICLE        = 220,
    NNTP_OK_HEAD           = 221,
    NNTP_OK_BODY           = 222,
}

[mydeveloperday]

Can you explain why this isn't just AlignConsecutiveAssignments: Consecutive

which gives

enum nntp_code {
  NNTP_INFO_HELP         = 100,
  NNTP_INFO_CAPABILITIES = 101,
  NNTP_INFO_DATE         = 111,
  NNTP_OK_BANNER_POST    = 200,
  NNTP_OK_BANNER_NOPOST  = 201,
  NNTP_OK_QUIT           = 205,
  NNTP_OK_COMPRESS       = 206,
  NNTP_OK_GROUP          = 211,
  NNTP_OK_LIST           = 215,
  NNTP_OK_ARTICLE        = 220,
  NNTP_OK_HEAD           = 221,
  NNTP_OK_BODY           = 222,
}

[Julien-Elie]

I agree AlignConsecutiveAssignments does the job in enum but I would just like to align assignments in enum, not everywhere in the source code.

[mydeveloperday]

This is doable but would require careful backwards compatibility considerations

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Assign the issue to you.
2. Fix the issue locally.
3. Run the test suite locally.
   3.1) Remember that the subdirectories under test/ create fine-grained testing targets, so you can
   e.g. use make check-clang-ast to only run Clang's AST tests.
4. Create a git commit
5. Run git clang-format HEAD~1 to format your changes.
6. Submit the patch to Phabricator.
   6.1) Detailed instructions can be found here

For more instructions on how to submit a patch to LLVM, see our documentation.

If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.

@llvm/issue-subscribers-good-first-issue

[gapisback]

Hello, Gentlepeople, I just started looking at LLVM git repo and this set of open issues.

This one to do with clang-format-ting is interesting to me as it's a non-core, non-compilation code change.
I am trying to teach myself compiler development, so would be interesting to work on this kind of outside the actual clang change.

I'm aware of the backwards-compatibility issue(s) and will take a crack at specifying the interface and behaviour once this issue is assigned to me.

Seems like there is some re-thinking on whether this is a 'new issue' or 'good first issue'; attn. @Endilll -- is this really that difficult?

[ @Julien-Elie - do you have ownership to assign? ] Will wait for the assigment to happen before engaging the people who commented on this issue with next-steps and a proposal.