clang-format: breaking parameters and arguments

[bertie-wheen]

It would be nice if I could unconditionally (or, particularly for arguments, whenever there are multiple) break parameter and argument lists (not just when they're long).

I am aware of:

• AlignAfterOpenBracket
• AllowAllParametersOfDeclarationOnNextLine
• BinPackParameters
• ExperimentalAutoDetectBinPacking
• PenaltyBreakBeforeFirstCallParameter
• PenaltyBreakOpenParenthesis

As far as I am aware though, this functionality is not (yet) available.

[llvmbot]

@llvm/issue-subscribers-clang-format

[mydeveloperday]

Can you explain

a) What you see
b) What you've tried
c) What you expect

[bertie-wheen]

I think most of your questions are answered by my initial post. I have tried the various options listed, and expect unconditional breaking of parameter/argument lists. Perhaps you need to see what I mean visually?

What I want is, in the case of argument lists (it's exactly the same with parameter lists), something like this:

function(
  argument_1,
  argument_2,
  argument_3);

Rather than;

function(argument_1, argument_2, argument_3);

Currently this can be configured to happen when the resulting one-line version would be long, but not to happen unconditionally, however long it would be.

[H-G-Hristov]

Isn't this issue the same as #53191 basically? And very similar to this new option for constructor initializers: PackConstructorInitializers PackConstructorInitializersStyle) clang-format 14
Being able to control the breaking of parameters and arguments of functions and maybe even for templates would be very useful.

[bertie-wheen]

#53191 is essentially an extension of it. I think your comments on that thread apply much more to this issue than that one, which is concerned not just with adding breaks between parameters/arguments, but additionally adding a break within a parameter, between its type and its name (assuming it has a name).

As much as I would like both, you could (and I think many people would) have #53190 without #53191.

I think it's really surprising that this isn't supported yet, as I would have thought it more common choice than some of the available options.

(I've been meaning to try and implement this and some other features, but I'm currently on a laptop with limited storage and I ran out of disk space when trying to build...)

[H-G-Hristov]

I think these issues are closely related so they should follow a similar design:

#53191
#53192
#53194
#53184

I hope you get around to implement it :)

[Zingam]

#51833
#23796
#40904

[Zingam]

https://reviews.llvm.org/D109557

AlignAfterOpenBracket: BlockIndent

[developer239]

I think most of your questions are answered by my initial post. I have tried the various options listed, and expect unconditional breaking of parameter/argument lists. Perhaps you need to see what I mean visually?

What I want is, in the case of argument lists (it's exactly the same with parameter lists), something like this:

function(
  argument_1,
  argument_2,
  argument_3);

Rather than;

function(argument_1, argument_2, argument_3);

Currently this can be configured to happen when the resulting one-line version would be long, but not to happen unconditionally, however long it would be.

Why not something like this though?

function(
  argument_1,
  argument_2,
  argument_3
);

I have a code like this and it is unreadable. How do I force the last bracket on a new line? 🙏

inputBoxes.erase(
  remove_if(
    inputBoxes.begin(),
    inputBoxes.end(),
    [&idx_t, &isSuppressed](const BoxInfo& f) {
      return isSuppressed[idx_t++];
    }),
    inputBoxes.end());

Edit:

😂

https://stackoverflow.com/questions/52158077/clang-format-closing-bracket-on-a-new-line