Clang should warn about chained comparisons like a > b > c #60256
Description
We had this = vs. == bug in Chromium recently:
int f(int);
int g(int a) {
a == f(a) > 1 ? 1 : f(a);
// stuff
}In most cases, Clang would catch a = vs == bug with -Wunused-comparison, but in this case the unintentional comparison became an operand to the ternary operator, and no warning fired.
Perhaps there should be warning for the general case of "chained comparisons" that would catch the above as well as code like:
void h(int a, int b, int c) {
if (a > b > c) {
// stuff...
}
}