Static initializers in locale.cpp .CRT$XCU

[chrdavis]

Ever since the below changes we have seen an increase in global static initializers contributing to windows modules .CRT$XCU. These impact performance as it increased code getting paged in and running at load time.

1a5af34#diff-463b7637691d6f87528cb5cfd02889eff500ca37ace5cb450cbd7829aa429488

[ldionne]

Is the new static initializer you're seeing locale::__imp::classic_locale_imp_? That one should be constinit so there should be no initializer. The other statics already existed before that patch and they are function-local statics.

Either way, this is a tradeoff between the current solution or more work at runtime (ref counting the default locale like we did before), and I am tempted to think that we are making the right call here.

[ldionne]

Closing as invalid until we have more information. For now my understanding is that this is constinit and shouldn't end up with a static initializer.