From 60ef4ac509016449dd9afb37c8cebfa82b94eab2 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Tue, 16 Jul 2024 19:50:51 +0000 Subject: [PATCH 1/6] [Workflows] Enable commit access requests via GitHub issues This updates the auto-labeler to match a specific issue title that is going to be used for requesting commit access and then add the infrastructure:commit-access-request label. This will notify the admin team who will be able to handle the request. See https://discourse.llvm.org/t/rfc-change-the-process-for-requesting-commit-access/80184 --- .github/new-issues-labeler.yml | 3 +++ llvm/docs/DeveloperPolicy.rst | 11 ++++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/new-issues-labeler.yml b/.github/new-issues-labeler.yml index a5933d7fc9b37..028b7fbd5bdda 100644 --- a/.github/new-issues-labeler.yml +++ b/.github/new-issues-labeler.yml @@ -27,3 +27,6 @@ 'bolt': - '/\bbolt(?!\-)\b/i' + +'infrastructure:commit-access-request': + - '/Request Commit Access/' diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst index f2ac46e6c04f2..95dd7251b4a13 100644 --- a/llvm/docs/DeveloperPolicy.rst +++ b/llvm/docs/DeveloperPolicy.rst @@ -476,11 +476,12 @@ Obtaining Commit Access ----------------------- We grant commit access to contributors with a track record of submitting high -quality patches. If you would like commit access, please send an email to -`Chris `_ with your GitHub username. This is true -for former contributors with SVN access as well as new contributors. If -approved, a GitHub invitation will be sent to your GitHub account. In case you -don't get notification from GitHub, go to +quality patches. If you would like commit access, please use this `link +&body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file +and issue and request commit access. Replace the string in the title +with your github username, and explain why you are requesting commit access in +the issue description. If approved, a GitHub invitation will be sent to your +GitHub account. In case you don't get notification from GitHub, go to `Invitation Link `_ directly. Once accept the invitation, you'll get commit access. From beda0a35441f5a21c6f55499b708db7377e2623d Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Mon, 29 Jul 2024 14:46:49 -0700 Subject: [PATCH 2/6] Address Review Comments: * Shorten label name * Fix typos --- .github/new-issues-labeler.yml | 2 +- llvm/docs/DeveloperPolicy.rst | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/new-issues-labeler.yml b/.github/new-issues-labeler.yml index 028b7fbd5bdda..860535bbe3083 100644 --- a/.github/new-issues-labeler.yml +++ b/.github/new-issues-labeler.yml @@ -28,5 +28,5 @@ 'bolt': - '/\bbolt(?!\-)\b/i' -'infrastructure:commit-access-request': +'infra:commit-access-request': - '/Request Commit Access/' diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst index 95dd7251b4a13..ac82a75d89474 100644 --- a/llvm/docs/DeveloperPolicy.rst +++ b/llvm/docs/DeveloperPolicy.rst @@ -478,12 +478,12 @@ Obtaining Commit Access We grant commit access to contributors with a track record of submitting high quality patches. If you would like commit access, please use this `link &body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file -and issue and request commit access. Replace the string in the title +an issue and request commit access. Replace the string in the title with your github username, and explain why you are requesting commit access in the issue description. If approved, a GitHub invitation will be sent to your GitHub account. In case you don't get notification from GitHub, go to `Invitation Link `_ directly. Once -accept the invitation, you'll get commit access. +you accept the invitation, you'll get commit access. Prior to obtaining commit access, it is common practice to request that someone with commit access commits on your behalf. When doing so, please From 326ce28dee3de54a661f3f551bb8f16af7067161 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Tue, 3 Sep 2024 15:46:03 -0700 Subject: [PATCH 3/6] Fix documentation build --- llvm/docs/DeveloperPolicy.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst index 45aca29373f3a..64fe790cd0ae0 100644 --- a/llvm/docs/DeveloperPolicy.rst +++ b/llvm/docs/DeveloperPolicy.rst @@ -476,8 +476,7 @@ Obtaining Commit Access ----------------------- We grant commit access to contributors that can provide a valid justification. -If you would like commit access, please use this `link -&body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file +If you would like commit access, please use this `link &body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file an issue and request commit access. Replace the string in the title with your github username, and explain why you are requesting commit access in the issue description. If approved, a GitHub invitation will be sent to your From 11801206cda5bdbadfce7ee4712285844708af8e Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Tue, 3 Sep 2024 15:53:28 -0700 Subject: [PATCH 4/6] Fix documentation again --- llvm/docs/DeveloperPolicy.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst index 64fe790cd0ae0..c0095b1594021 100644 --- a/llvm/docs/DeveloperPolicy.rst +++ b/llvm/docs/DeveloperPolicy.rst @@ -476,7 +476,7 @@ Obtaining Commit Access ----------------------- We grant commit access to contributors that can provide a valid justification. -If you would like commit access, please use this `link &body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file +If you would like commit access, please use this `link `_ to file an issue and request commit access. Replace the string in the title with your github username, and explain why you are requesting commit access in the issue description. If approved, a GitHub invitation will be sent to your From e4b65120ef6fae52610a5a731b466d7828bbf6a0 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Mon, 11 Nov 2024 11:10:25 -0800 Subject: [PATCH 5/6] Update llvm/docs/DeveloperPolicy.rst Co-authored-by: Vlad Serebrennikov --- llvm/docs/DeveloperPolicy.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst index c0095b1594021..d1e72996d959a 100644 --- a/llvm/docs/DeveloperPolicy.rst +++ b/llvm/docs/DeveloperPolicy.rst @@ -479,7 +479,7 @@ We grant commit access to contributors that can provide a valid justification. If you would like commit access, please use this `link `_ to file an issue and request commit access. Replace the string in the title with your github username, and explain why you are requesting commit access in -the issue description. If approved, a GitHub invitation will be sent to your +the issue description. If approved, a GitHub invitation will be sent to your GitHub account. In case you don't get notification from GitHub, go to `Invitation Link `_ directly. Once you accept the invitation, you'll get commit access. From a0070b3bc6f0908b644d094021478be03dab97e7 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Mon, 11 Nov 2024 11:10:35 -0800 Subject: [PATCH 6/6] Update llvm/docs/DeveloperPolicy.rst Co-authored-by: Vlad Serebrennikov --- llvm/docs/DeveloperPolicy.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst index d1e72996d959a..354c3fa2bd624 100644 --- a/llvm/docs/DeveloperPolicy.rst +++ b/llvm/docs/DeveloperPolicy.rst @@ -477,7 +477,7 @@ Obtaining Commit Access We grant commit access to contributors that can provide a valid justification. If you would like commit access, please use this `link `_ to file -an issue and request commit access. Replace the string in the title +an issue and request commit access. Replace the string in the title with your github username, and explain why you are requesting commit access in the issue description. If approved, a GitHub invitation will be sent to your GitHub account. In case you don't get notification from GitHub, go to