From debf7fb1068fe1a406a8c2f08edbbfb114d6f1c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Mon, 12 Aug 2024 14:10:29 +0300 Subject: [PATCH 1/2] [libcxx] [test] Mark gdb_pretty_printer_test.sh.cpp as unsupported on Windows In practice, this test hasn't been run by any of the Windows configurations so far, because it has been excluded by the "UNSUPPORTED: clang-18, clang-19" line - but it does end up failing if running with e.g. clang-20 on Windows. As the test fails on more fundamental issues on Windows, mark it outright unsupported on this platform; this fixes testing libcxx with a recent nightly version of Clang from git main. --- libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp b/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp index 4c2b483914f47..2c8534977febc 100644 --- a/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp +++ b/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp @@ -20,6 +20,9 @@ // support gdb anymore, favoring lldb instead. // UNSUPPORTED: android +// This test doesn't work as such on Windows. +// UNSUPPORTED: windows + // RUN: %{cxx} %{flags} %s -o %t.exe %{compile_flags} -g %{link_flags} // Ensure locale-independence for unicode tests. // RUN: env LANG=en_US.UTF-8 %{gdb} -nx -batch -iex "set autoload off" -ex "source %S/../../../utils/gdb/libcxx/printers.py" -ex "python register_libcxx_printer_loader()" -ex "source %S/gdb_pretty_printer_test.py" %t.exe From 4e72b6df2a9daab9ad90ec71078a5152d1645086 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Mon, 12 Aug 2024 15:38:03 +0300 Subject: [PATCH 2/2] [libcxx] [test] Enable gdb_pretty_printer_test.sh.cpp for clang With current versions the CI image, this test does pass, with both Clang 17, 18 and 19 - so there doesn't seem to be anything Clang version specific in it. --- libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp b/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp index 2c8534977febc..439dbab94eb69 100644 --- a/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp +++ b/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp @@ -11,9 +11,6 @@ // UNSUPPORTED: no-localization // UNSUPPORTED: c++03 -// TODO: Investigate these failures which break the CI. -// UNSUPPORTED: clang-17, clang-18, clang-19 - // The Android libc++ tests are run on a non-Android host, connected to an // Android device over adb. gdb needs special support to make this work (e.g. // gdbclient.py, ndk-gdb.py, gdbserver), and the Android organization doesn't