Skip to content

Conversation

@brad0
Copy link
Contributor

@brad0 brad0 commented Aug 28, 2024

No description provided.

@brad0 brad0 requested a review from a team as a code owner August 28, 2024 00:30
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Aug 28, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 28, 2024

@llvm/pr-subscribers-libcxx

Author: Brad Smith (brad0)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/106315.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/buildkite-pipeline.yml (+12)
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index d02d11ae7a756b..111fce874e743f 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -173,6 +173,18 @@ steps:
       os: freebsd
     <<: *common
 
+- group: ':openbsd: OpenBSD'
+  steps:
+  - label: OpenBSD -current amd64
+    command: libcxx/utils/ci/run-buildbot generic-cxx17
+    env:
+      CC: clang
+      CXX: clang++
+    agents:
+      queue: libcxx-builders
+      os: openbsd
+    <<: *common
+
 - group: ':android: Android'
   steps:
   - label: Android 5.0, x86 NDK

@brad0 brad0 force-pushed the libcxx_openbsd_ci branch 2 times, most recently from ae1345a to 2d10c7b Compare August 28, 2024 01:21
@brad0 brad0 force-pushed the libcxx_openbsd_ci branch from 2d10c7b to 26ef598 Compare August 28, 2024 08:17

// TODO: Find out how altivec changes things and allow vectorizations there too.
#if _LIBCPP_STD_VER >= 14 && defined(_LIBCPP_CLANG_VER) && !defined(__ALTIVEC__)
#if _LIBCPP_STD_VER >= 14 && defined(_LIBCPP_CLANG_VER) && _LIBCPP_CLANG_VER >= 1700 && !defined(__ALTIVEC__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't support anything older than Clang 17 (actually 18, since we're in the LLVM 20 phase).

Comment on lines +36 to +37
# if _LIBCPP_CLANG_VER < 1600
# warning "Libc++ only supports Clang 16 and later"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

@philnik777
Copy link
Contributor

@brad0 Do you plan to continue working on this?

@philnik777
Copy link
Contributor

Closing for now to clean up the review queue. If you want to continue working on this feel free to re-open.

@philnik777 philnik777 closed this Jan 9, 2025
@brad0
Copy link
Contributor Author

brad0 commented Jan 9, 2025

@brad0 Do you plan to continue working on this?

I would like to, but it's stuck in a situation that can't be resolved.

@philnik777
Copy link
Contributor

@brad0 Do you plan to continue working on this?

I would like to, but it's stuck in a situation that can't be resolved.

Is that something we can help resolving?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants