[lldb-dap] Add: show return value on step out #106907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-lldb Author: None (Da-Viper) Changesshow_return_values.mp4Full diff: https://github.com/llvm/llvm-project/pull/106907.diff 1 Files Affected:
diff --git a/lldb/tools/lldb-dap/lldb-dap.cpp b/lldb/tools/lldb-dap/lldb-dap.cpp
index c5c4b09f15622b..c9116c62c46b5e 100644
--- a/lldb/tools/lldb-dap/lldb-dap.cpp
+++ b/lldb/tools/lldb-dap/lldb-dap.cpp
@@ -3801,6 +3801,17 @@ void request_variables(const llvm::json::Object &request) {
variable_name_counts[GetNonNullVariableName(variable)]++;
}
+ // Show return value if there is any ( in the top frame )
+ auto process = g_dap.target.GetProcess();
+ auto selectedThread = process.GetSelectedThread();
+ lldb::SBValue stopReturnValue = selectedThread.GetStopReturnValue();
+ if (stopReturnValue.IsValid() &&
+ (selectedThread.GetSelectedFrame().GetFrameID() == 0)) {
+ auto renamedReturnValue = stopReturnValue.Clone("(Return Value)");
+ variables.emplace_back(
+ CreateVariable(renamedReturnValue,0, UINT64_MAX, hex, false));
+ }
+
// Now we construct the result with unique display variable names
for (auto i = start_idx; i < end_idx; ++i) {
lldb::SBValue variable = top_scope->GetValueAtIndex(i);
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
walter-erquinigo
requested changes
Sep 10, 2024
Member
walter-erquinigo
left a comment
walter-erquinigo
left a comment
There was a problem hiding this comment.
This looks much better!
Could you please write some tests?
Contributor
Author
|
@JDevlieghere was away for sometime could you please review this. thanks |
da-viper
force-pushed
the
show_return_value_on_step_out
branch
from
a5e336a to
42e3bd5
Compare
Contributor
Author
|
Is there any that needs to be done one the PR? |
clayborg
approved these changes
Feb 28, 2025
Collaborator
clayborg
left a comment
clayborg
left a comment
There was a problem hiding this comment.
Looks good as long as this is well tested!
Member
|
@da-viper Can you rebase and merge this PR by yourself? Or do you need somebody to merge it on your behalf? |
Explicitly check for the return value variable
da-viper
force-pushed
the
show_return_value_on_step_out
branch
from
04db61f to
4453e42
Compare
Contributor
Author
I rebased but I do not have the necessary permissions to merge |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/13574 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/12219 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/6707 Here is the relevant piece of the build log for the reference |
SquallATF
pushed a commit
to SquallATF/llvm-project
that referenced
this pull request
Jun 13, 2025
SquallATF
pushed a commit
to SquallATF/llvm-project
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show_return_values.mp4