Skip to content

[AIX][CMake] Disable openmp as LLVM_ENABLE_PROJECTS #110152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[AIX][CMake] Disable openmp as LLVM_ENABLE_PROJECTS #110152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e763ee
Disable openmp as LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_RUNTIM…
DanielCChen Sep 26, 2024
d3bfeda
Remove the dup line to address review comment.
DanielCChen Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions llvm/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ endif()
# This allows an easy way of setting up a build directory for llvm and another
# one for llvm+clang+... using the same sources.
set(LLVM_ALL_PROJECTS "bolt;clang;clang-tools-extra;compiler-rt;cross-project-tests;libc;libclc;lld;lldb;mlir;openmp;polly;pstl")
if (${CMAKE_SYSTEM_NAME} MATCHES "AIX")
# Disallow 'openmp' as a LLVM PROJECT on AIX as the supported way is to use
# LLVM_ENABLE_RUNTIMES.
list(REMOVE_ITEM LLVM_ALL_PROJECTS openmp)
endif()

# The flang project is not yet part of "all" projects (see C++ requirements)
Copy link
Member

@daltenty daltenty Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is a dup. I think this is a duplicate/copy-paste error:

Suggested change
# The flang project is not yet part of "all" projects (see C++ requirements)

Copy link
Contributor Author

@DanielCChen DanielCChen Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. The dup line is removed.

set(LLVM_EXTRA_PROJECTS "flang")
# List of all known projects in the mono repo
Expand Down