Skip to content

[llvm] Add serialization to uint32_t for FixedPointSemantics #110288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[llvm] Add serialization to uint32_t for FixedPointSemantics #110288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions llvm/include/llvm/ADT/APFixedPoint.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,15 @@ class FixedPointSemantics {
}
bool operator!=(FixedPointSemantics Other) const { return !(*this == Other); }

/// Convert the semantics to a 32-bit unsigned integer.
/// The result is dependent on the host endianness and not stable across LLVM
/// versions. See getFromOpaqueInt() to convert it back to a
/// FixedPointSemantics object.
uint32_t toOpaqueInt() const;
/// Create a FixedPointSemantics object from an integer created via
/// toOpaqueInt().
static FixedPointSemantics getFromOpaqueInt(uint32_t);

private:
unsigned Width : WidthBitWidth;
signed int LsbWeight : LsbWeightBitWidth;
Expand Down
10 changes: 10 additions & 0 deletions llvm/lib/Support/APFixedPoint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,16 @@ void FixedPointSemantics::print(llvm::raw_ostream &OS) const {
OS << "IsSaturated=" << IsSaturated;
}

uint32_t FixedPointSemantics::toOpaqueInt() const {
return llvm::bit_cast<uint32_t>(*this);
}

FixedPointSemantics FixedPointSemantics::getFromOpaqueInt(uint32_t I) {
FixedPointSemantics F(0, 0, false, false, false);
std::memcpy(&F, &I, sizeof(F));
return F;
}

APFixedPoint APFixedPoint::convert(const FixedPointSemantics &DstSema,
bool *Overflow) const {
APSInt NewVal = Val;
Expand Down
31 changes: 31 additions & 0 deletions llvm/unittests/ADT/APFixedPointTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1274,4 +1274,35 @@ TEST(FixedPoint, div) {
true, false, false)));
}

TEST(FixedPoint, semanticsSerialization) {
auto roundTrip = [](FixedPointSemantics FPS) -> bool {
uint32_t I = FPS.toOpaqueInt();
FixedPointSemantics FPS2 = FixedPointSemantics::getFromOpaqueInt(I);
return FPS == FPS2;
};

ASSERT_TRUE(roundTrip(getS32Pos2()));
ASSERT_TRUE(roundTrip(getU8Pos4()));
ASSERT_TRUE(roundTrip(getS16Neg18()));
ASSERT_TRUE(roundTrip(getU8Neg10()));
ASSERT_TRUE(roundTrip(getPadULFractSema()));
ASSERT_TRUE(roundTrip(getPadUFractSema()));
ASSERT_TRUE(roundTrip(getPadUSFractSema()));
ASSERT_TRUE(roundTrip(getPadULAccumSema()));
ASSERT_TRUE(roundTrip(getPadUAccumSema()));
ASSERT_TRUE(roundTrip(getPadUSAccumSema()));
ASSERT_TRUE(roundTrip(getULFractSema()));
ASSERT_TRUE(roundTrip(getUFractSema()));
ASSERT_TRUE(roundTrip(getUSFractSema()));
ASSERT_TRUE(roundTrip(getULAccumSema()));
ASSERT_TRUE(roundTrip(getUAccumSema()));
ASSERT_TRUE(roundTrip(getUSAccumSema()));
ASSERT_TRUE(roundTrip(getLFractSema()));
ASSERT_TRUE(roundTrip(getFractSema()));
ASSERT_TRUE(roundTrip(getSFractSema()));
ASSERT_TRUE(roundTrip(getLAccumSema()));
ASSERT_TRUE(roundTrip(getAccumSema()));
ASSERT_TRUE(roundTrip(getSAccumSema()));
}

} // namespace
Loading