Skip to content

[ArgPromotion] Consider InvokeInst in Caller alias analysis #110335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2024
+76 −8
Merged

[ArgPromotion] Consider InvokeInst in Caller alias analysis #110335

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9855319
[ArgPromotion] Consider InvokeInst in Caller alias analysis
hazzlim Sep 27, 2024
7ec391d
Address review comments
hazzlim Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,10 +491,8 @@ static bool isArgUnmodifiedByAllCalls(Argument *Arg,
FunctionAnalysisManager &FAM) {
for (User *U : Arg->getParent()->users()) {

// Bail if we find an unexpected (non CallInst) use of the function.
auto *Call = dyn_cast<CallInst>(U);
if (!Call)
return false;
assert(isa<CallBase>(U) && "Expected all users of Function to be CallBase");
CallBase *Call = cast<CallBase>(U);
Copy link
Contributor

@nikic nikic Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert(isa<CallBase>(U) && "Expected all users of Function to be CallBase");
CallBase *Call = cast<CallBase>(U);
auto *Call = cast<CallBase>(U);

cast performs an implicit isa assert.

Copy link
Contributor Author

@hazzlim hazzlim Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - updated to remove the superfluous assert(), and added some tests for invoke instructions.


MemoryLocation Loc =
MemoryLocation::getForArgument(Call, Arg->getArgNo(), nullptr);
Expand Down
Loading