Skip to content

[clang][CGObjCMac] Unionize identical llvm types (NFC) #110422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[clang][CGObjCMac] Unionize identical llvm types (NFC) #110422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions clang/lib/CodeGen/CGObjCMac.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,16 +173,18 @@ class ObjCCommonTypesHelper {

public:
llvm::IntegerType *ShortTy, *IntTy, *LongTy;
llvm::PointerType *Int8PtrTy, *Int8PtrPtrTy;

union {
llvm::PointerType *Int8PtrTy;
llvm::PointerType *Int8PtrPtrTy;
};

llvm::PointerType *Int8PtrProgramASTy;
llvm::Type *IvarOffsetVarTy;

/// ObjectPtrTy - LLVM type for object handles (typeof(id))
llvm::PointerType *ObjectPtrTy;

/// PtrObjectPtrTy - LLVM type for id *
llvm::PointerType *PtrObjectPtrTy;

/// SelectorPtrTy - LLVM type for selector handles (typeof(SEL))
llvm::PointerType *SelectorPtrTy;

Expand Down Expand Up @@ -212,8 +214,6 @@ class ObjCCommonTypesHelper {

/// SuperTy - LLVM type for struct objc_super.
llvm::StructType *SuperTy;
/// SuperPtrTy - LLVM type for struct objc_super *.
llvm::PointerType *SuperPtrTy;

/// PropertyTy - LLVM type for struct objc_property (struct _prop_t
/// in GCC parlance).
Expand All @@ -222,16 +222,23 @@ class ObjCCommonTypesHelper {
/// PropertyListTy - LLVM type for struct objc_property_list
/// (_prop_list_t in GCC parlance).
llvm::StructType *PropertyListTy;
/// PropertyListPtrTy - LLVM type for struct objc_property_list*.
llvm::PointerType *PropertyListPtrTy;

// MethodTy - LLVM type for struct objc_method.
llvm::StructType *MethodTy;

/// CacheTy - LLVM type for struct objc_cache.
llvm::Type *CacheTy;
/// CachePtrTy - LLVM type for struct objc_cache *.
llvm::PointerType *CachePtrTy;

union {
/// PtrObjectPtrTy - LLVM type for id *
llvm::PointerType *PtrObjectPtrTy;
/// SuperPtrTy - LLVM type for struct objc_super *.
llvm::PointerType *SuperPtrTy;
/// PropertyListPtrTy - LLVM type for struct objc_property_list*.
llvm::PointerType *PropertyListPtrTy;
/// CachePtrTy - LLVM type for struct objc_cache *.
llvm::PointerType *CachePtrTy;
};

llvm::FunctionCallee getGetPropertyFn() {
CodeGen::CodeGenTypes &Types = CGM.getTypes();
Expand Down
Loading