Skip to content

[SPARC] Fix regression from UpgradeDataLayoutString change #110608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2024
Merged

[SPARC] Fix regression from UpgradeDataLayoutString change #110608

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f9c492
[SPARC] Fix bugpoint regression from UpgradeDataLayoutString change
koachan Sep 30, 2024
d86ada5
Take out the assert; do conditional insert instead
koachan Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions llvm/lib/IR/AutoUpgrade.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5519,12 +5519,12 @@ std::string llvm::UpgradeDataLayoutString(StringRef DL, StringRef TT) {

if (T.isSPARC()) {
// Add "-i128:128"
std::string I64 = "-i64:64";
std::string I128 = "-i128:128";
if (!StringRef(Res).contains(I128)) {
size_t Pos = Res.find(I64);
assert(Pos != size_t(-1) && "no i64 data layout found!");
Res.insert(Pos + I64.size(), I128);
SmallVector<StringRef, 4> Groups;
Regex R("^([Ee](-[mpi][^-]*)*)((-[^mpi][^-]*)*)$");
if (R.match(Res, &Groups))
Res = (Groups[1] + I128 + Groups[3]).str();
}
return Res;
}
Expand Down
Loading