Skip to content

[SYCL][LLVM] Adding property set I/O library for SYCL #110771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

[SYCL][LLVM] Adding property set I/O library for SYCL #110771

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7350a52
[SYCL][LLVM] Adding property set I/O library for SYCL
asudarsa Sep 27, 2024
526633f
Move from union to variant
asudarsa Oct 2, 2024
944841a
Add missing implementation of encode/decode functions
asudarsa Oct 2, 2024
f528b64
More changes due to shift from Union to std::variant
asudarsa Oct 3, 2024
0b4ad71
Address review comments
asudarsa Oct 3, 2024
cd9874a
Fix clang format issue
asudarsa Oct 3, 2024
de19806
Remove changes to Base64 implementation and use existing implementation
asudarsa Oct 9, 2024
20a7d75
Add SYCL prefix to PropertySet etc.
asudarsa Oct 9, 2024
025503a
Add tests expected to fail and make sure errors are caught
asudarsa Oct 9, 2024
6550bf5
Update test to pass when assertions are turned on
asudarsa Oct 10, 2024
4de3158
Replace simple llvm_unreachable with asserts
asudarsa Oct 10, 2024
b15e201
Addressed the following comments:
asudarsa Oct 14, 2024
50de423
Avoid memory leak for byte array
asudarsa Oct 15, 2024
0d5af17
Use unique_ptr for Byte Array
asudarsa Oct 15, 2024
269d661
Minor change to use switch-case instead of if-then-else
asudarsa Oct 16, 2024
60526f4
Fix formatting issue
asudarsa Oct 16, 2024
498eaf0
Add more tests for PropertySetIO usage
asudarsa Oct 21, 2024
dec58b4
Remove redundant print statements
asudarsa Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions llvm/include/llvm/Support/SYCLPropertySetIO.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,13 @@ class SYCLPropertyValue {
return static_cast<Type>(T);
}

~SYCLPropertyValue() {}

~SYCLPropertyValue() {
if (std::holds_alternative<std::byte *>(Val)) {
auto ByteArrayVal = std::get<std::byte *>(Val);
if (ByteArrayVal)
delete[] ByteArrayVal;
Copy link
Contributor

@arsenm arsenm Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just use unique_ptr

Copy link
Contributor Author

@asudarsa asudarsa Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arsenm

I will give it another shot. I had a bit of an issue in getting unique_ptr to work with remainder of the code. I must be missing something. I will put up a change soon. Thanks again for looking into this.

Sincerely

Copy link
Contributor Author

@asudarsa asudarsa Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arsenm

I added use of unique_ptr in 0d5af17
It was a good learning curve for me.

Thanks
Sincerely

}
}
SYCLPropertyValue() = default;

SYCLPropertyValue(Type Ty) {
Expand Down