Skip to content

[LLDB][DYLD] Remove logic around not rebasing when main executable has a load address #110885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2024
Merged

[LLDB][DYLD] Remove logic around not rebasing when main executable has a load address #110885

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ed6e20
Remove additional logic to disable the dynamic loader when the main e…
Jlalond Oct 2, 2024
071b7fa
Change the test that emits an invalid .so
Jlalond Oct 2, 2024
e4f0b83
Have to keep the name variable
Jlalond Oct 2, 2024
054c74c
Remove test change
Jlalond Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,21 +108,6 @@ void DynamicLoaderPOSIXDYLD::DidAttach() {
// if we dont have a load address we cant re-base
bool rebase_exec = load_offset != LLDB_INVALID_ADDRESS;

// if we have a valid executable
if (executable_sp.get()) {
lldb_private::ObjectFile *obj = executable_sp->GetObjectFile();
if (obj) {
// don't rebase if the module already has a load address
Target &target = m_process->GetTarget();
Address addr = obj->GetImageInfoAddress(&target);
if (addr.GetLoadAddress(&target) != LLDB_INVALID_ADDRESS)
rebase_exec = false;
}
} else {
// no executable, nothing to re-base
rebase_exec = false;
}

// if the target executable should be re-based
if (rebase_exec) {
ModuleList module_list;
Expand Down
2 changes: 0 additions & 2 deletions lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,6 @@ def test_relative_module_name(self):
old_cwd = os.getcwd()
self.addTearDownHook(lambda: os.chdir(old_cwd))
os.chdir(self.getBuildDir())
name = "file-with-a-name-unlikely-to-exist-in-the-current-directory.so"
open(name, "a").close()
modules = self.get_minidump_modules(
self.getSourcePath("relative_module_name.yaml")
)
Expand Down
Loading